Skip to content

Commit

Permalink
[Container Registry] Acr beta3 (Azure#18667)
Browse files Browse the repository at this point in the history
* more detailed ContentProperties

* updating generated for beta3

* updating for new generated code

* changelog update

* updating the model docstrings

* more docstrings

* renaming param to properties

* updating generated

* same type for get and set operations

* single client implementation

* new generated, feedback from arch board

* anonymous tests

* fixed up all tests

* formatting

* turning non writeables into properties

* fixed up a couple tests

* cleaning up recordings files

* changelog

* get_tag_properties -> get_tag

* PATCH operations prefixed with set

* pylint fixes

* new recordings

* gt to gt or equal

* adding overloaded update methods on sync

* added to async, no luck with teleport

* lint fixes and test changes

* fixing type hints

* updated swagger

* updating generated code

* fixing fixture

* issys comments

* updating changelog

* modifications from annas comments

* adding docstring about swallowing 404

* renaming methods to align with other languages

* adding delete tests to anon

* adding tests for update in anon

* removing comment

* fixing fixture

* fixing mgmt import

* adding better exception handling

* formatting

* searching wrong area

* removing early return

* fixing spelling

* adding delete callback for better verification

* removing try/excepts

* lint fixes

* removing callback type hint

* removing callback

* unused import

* fixing changelog
  • Loading branch information
seankane-msft authored Jun 3, 2021
1 parent 4609245 commit 05ed2d1
Show file tree
Hide file tree
Showing 176 changed files with 30,528 additions and 14,862 deletions.
5 changes: 4 additions & 1 deletion sdk/containerregistry/azure-containerregistry/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# Release History

## 1.0.0b3 (2021-06-08)

* Removes `DeleteRepositoryResult`. `ContainerRegistryClient.delete_repository` now returns `None`
* Removed `writeable_properties` objects, placing `can_delete/read/write/list` properties on the immediate `Repository/Tag/ArtifactManifestProperties` objects
* Removed `ContainerRepository` and `RegistryArtifact` classes. The methods for acting on a repository and a registry artifact are now contained in the `ContainerRegistryClient` object.
* The `delete_repository` and `get_repository` methods parameters have been renamed from `repository_name` to `repository`.

## 1.0.0b2 (2021-05-11)
* Rename `DeletedRepositoryResult` to `DeleteRepositoryResult`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,15 @@
# --------------------------------------------------------------------------

from ._container_registry_client import ContainerRegistryClient
from ._container_repository import ContainerRepository
from ._models import (
ArtifactArchitecture,
ArtifactOperatingSystem,
ContentProperties,
DeleteRepositoryResult,
ManifestOrder,
ArtifactManifestProperties,
RepositoryProperties,
TagOrder,
ArtifactTagProperties,
)
from ._registry_artifact import RegistryArtifact
from ._version import VERSION

__version__ = VERSION
Expand All @@ -28,10 +24,6 @@
"ArtifactArchitecture",
"ArtifactOperatingSystem",
"ContainerRegistryClient",
"ContainerRepository",
"ContentProperties",
"DeleteRepositoryResult",
"RegistryArtifact",
"ManifestOrder",
"ArtifactManifestProperties",
"RepositoryProperties",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
if TYPE_CHECKING:
from azure.core.credentials import TokenCredential
from azure.core.pipeline import PipelineRequest, PipelineResponse
from typing import Optional


class ContainerRegistryChallengePolicy(HTTPPolicy):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Licensed under the MIT License.
# ------------------------------------
from enum import Enum
from typing import TYPE_CHECKING, Dict, Any
from typing import TYPE_CHECKING, Dict, Any, Optional

from azure.core.pipeline.transport import HttpTransport

Expand All @@ -31,7 +31,7 @@ class ContainerRegistryBaseClient(object):
"""

def __init__(self, endpoint, credential, **kwargs):
# type: (str, TokenCredential, Dict[str, Any]) -> None
# type: (str, Optional[TokenCredential], Dict[str, Any]) -> None
auth_policy = ContainerRegistryChallengePolicy(credential, endpoint)
self._client = ContainerRegistry(
credential=credential,
Expand Down
Loading

0 comments on commit 05ed2d1

Please sign in to comment.