[Container Registry] Acr beta3 #18667
Conversation
ghost
added
the
|
/azp run python - containerregistry - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/check-enforcer reset |
sdk/containerregistry/azure-containerregistry/tests/testcase.py
Outdated
Show resolved
Hide resolved
|
|
||
|
|
||
| # Moving this out of testcase so the fixture and individual tests can use it | ||
| def import_image(repository, tags): | ||
| mgmt_client = ContainerRegistryManagementClient( | ||
| DefaultAzureCredential(), os.environ["CONTAINERREGISTRY_SUBSCRIPTION_ID"] | ||
| DefaultAzureCredential(), os.environ["CONTAINERREGISTRY_SUBSCRIPTION_ID"], api_version="2019-05-01" |
There was a problem hiding this comment.
just checking why you're specifying api version here. is this a test for an older api version?
There was a problem hiding this comment.
This is for the management plane client, I use mgmt-plane to load the registry for tests.
sdk/containerregistry/azure-containerregistry/azure/containerregistry/_models.py
Outdated
Show resolved
Hide resolved
| try: | ||
| await self._client.container_registry.delete_repository(repository, **kwargs) | ||
| except ResourceNotFoundError as exc: | ||
| if "Not Found" in exc.reason: |
There was a problem hiding this comment.
Checking reason is generally redundant - as it's just a string code associated with the status code. It's not something the service configures.
There was a problem hiding this comment.
Ahh, the swallowing 404s has been added to the swagger so the error returned is pretty vague. I can check more in depth but the raised error would look like "Not Found" to the user.
There was a problem hiding this comment.
I added a callback to do a check to make sure "object UNKNOWN" was in the response body
There was a problem hiding this comment.
Yeah but there's no point in adding this. If there's no deserialized body to the error that we can check for details, then your only choice is to catch and pass ResourceNotFoundError in its entirety.
| self._client.container_registry.delete_repository(repository, **kwargs) | ||
| except ResourceNotFoundError: | ||
| pass | ||
| self._client.container_registry.delete_repository(repository, **kwargs) |
There was a problem hiding this comment.
did you end up not doing the 404 check?
There was a problem hiding this comment.
Pushing it back to the next sprint
#18463