Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Container Registry] Acr beta3 #18667

Merged
merged 54 commits into from
Jun 3, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
1c8ce59
more detailed ContentProperties
seankane-msft May 11, 2021
09ea362
updating generated for beta3
seankane-msft May 11, 2021
2a7d7f3
updating for new generated code
seankane-msft May 12, 2021
312a72d
changelog update
seankane-msft May 12, 2021
9587da8
updating the model docstrings
seankane-msft May 12, 2021
ab573b5
more docstrings
seankane-msft May 12, 2021
f56b546
renaming param to properties
seankane-msft May 14, 2021
7ff1023
updating generated
seankane-msft May 14, 2021
be2ae83
same type for get and set operations
seankane-msft May 17, 2021
2605d5f
single client implementation
seankane-msft May 17, 2021
ff4331c
new generated, feedback from arch board
seankane-msft May 19, 2021
f1e2ffe
anonymous tests
seankane-msft May 19, 2021
1031a72
fixed up all tests
seankane-msft May 19, 2021
41a8a3b
formatting
seankane-msft May 19, 2021
e4bb085
turning non writeables into properties
seankane-msft May 19, 2021
0df149a
fixed up a couple tests
seankane-msft May 19, 2021
e1054b5
cleaning up recordings files
seankane-msft May 19, 2021
fe874fb
merge conflicts
seankane-msft May 19, 2021
845d59e
changelog
seankane-msft May 19, 2021
2e4ccc3
get_tag_properties -> get_tag
seankane-msft May 19, 2021
381a7c9
PATCH operations prefixed with set
seankane-msft May 19, 2021
d804d37
pylint fixes
seankane-msft May 19, 2021
42d4f39
new recordings
seankane-msft May 19, 2021
55374ce
gt to gt or equal
seankane-msft May 19, 2021
46e52ac
adding overloaded update methods on sync
seankane-msft May 20, 2021
01d809f
added to async, no luck with teleport
seankane-msft May 20, 2021
55b4129
lint fixes and test changes
seankane-msft May 20, 2021
67f0435
fixing type hints
seankane-msft May 24, 2021
f4aea9b
updated swagger
seankane-msft May 24, 2021
f167337
updating generated code
seankane-msft May 25, 2021
bdc135e
fixing fixture
seankane-msft May 25, 2021
3310952
issys comments
seankane-msft May 25, 2021
025c51e
updating changelog
seankane-msft May 26, 2021
8b07e00
modifications from annas comments
seankane-msft May 26, 2021
43ce7ce
adding docstring about swallowing 404
seankane-msft May 27, 2021
a384a2b
renaming methods to align with other languages
seankane-msft May 28, 2021
f6379ad
adding delete tests to anon
seankane-msft May 28, 2021
0124da5
adding tests for update in anon
seankane-msft May 28, 2021
906e2aa
removing comment
seankane-msft May 28, 2021
32f913f
fixing fixture
seankane-msft May 28, 2021
0745f8f
fixing mgmt import
seankane-msft May 28, 2021
f225b81
adding better exception handling
seankane-msft Jun 1, 2021
6ef953e
formatting
seankane-msft Jun 1, 2021
da40fe5
searching wrong area
seankane-msft Jun 1, 2021
aa9a7eb
removing early return
seankane-msft Jun 2, 2021
03107af
fixing spelling
seankane-msft Jun 2, 2021
317c8d0
changelog conflicts
seankane-msft Jun 2, 2021
d72edd3
adding delete callback for better verification
seankane-msft Jun 2, 2021
580a55c
removing try/excepts
seankane-msft Jun 2, 2021
4c6c569
lint fixes
seankane-msft Jun 3, 2021
9ebe8e4
removing callback type hint
seankane-msft Jun 3, 2021
841dd83
removing callback
seankane-msft Jun 3, 2021
55d6ed0
unused import
seankane-msft Jun 3, 2021
1d41c5d
fixing changelog
seankane-msft Jun 3, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion sdk/containerregistry/azure-containerregistry/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# Release History

## 1.0.0b3 (2021-06-08)

* Removes `DeleteRepositoryResult`. `ContainerRegistryClient.delete_repository` now returns `None`
* Removed `writeable_properties` objects, placing `can_delete/read/write/list` properties on the immediate `Repository/Tag/ArtifactManifestProperties` objects
* Removed `ContainerRepository` and `RegistryArtifact` classes. The methods for acting on a repository and a registry artifact are now contained in the `ContainerRegistryClient` object.
* The `delete_repository` and `get_repository` methods parameters have been renamed from `repository_name` to `repository`.

## 1.0.0b2 (2021-05-11)
* Rename `DeletedRepositoryResult` to `DeleteRepositoryResult`
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,19 +7,15 @@
# --------------------------------------------------------------------------

from ._container_registry_client import ContainerRegistryClient
from ._container_repository import ContainerRepository
from ._models import (
ArtifactArchitecture,
ArtifactOperatingSystem,
ContentProperties,
DeleteRepositoryResult,
ManifestOrder,
ArtifactManifestProperties,
RepositoryProperties,
TagOrder,
ArtifactTagProperties,
)
from ._registry_artifact import RegistryArtifact
from ._version import VERSION

__version__ = VERSION
Expand All @@ -28,10 +24,6 @@
"ArtifactArchitecture",
"ArtifactOperatingSystem",
"ContainerRegistryClient",
"ContainerRepository",
"ContentProperties",
"DeleteRepositoryResult",
"RegistryArtifact",
"ManifestOrder",
"ArtifactManifestProperties",
"RepositoryProperties",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
if TYPE_CHECKING:
from azure.core.credentials import TokenCredential
from azure.core.pipeline import PipelineRequest, PipelineResponse
from typing import Optional


class ContainerRegistryChallengePolicy(HTTPPolicy):
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# Licensed under the MIT License.
# ------------------------------------
from enum import Enum
from typing import TYPE_CHECKING, Dict, Any
from typing import TYPE_CHECKING, Dict, Any, Optional

from azure.core.pipeline.transport import HttpTransport

Expand All @@ -31,7 +31,7 @@ class ContainerRegistryBaseClient(object):
"""

def __init__(self, endpoint, credential, **kwargs):
# type: (str, TokenCredential, Dict[str, Any]) -> None
# type: (str, Optional[TokenCredential], Dict[str, Any]) -> None
auth_policy = ContainerRegistryChallengePolicy(credential, endpoint)
self._client = ContainerRegistry(
credential=credential,
Expand Down
Loading