Update for summary and export, fix bugs and incorporate CRE workbook#159
Merged
tsubasaxZZZ merged 7 commits intoAzure:mainfrom Apr 16, 2024
Merged
Conversation
tsubasaxZZZ
changed the title
| DBGeoStorage=dcountif(Name, OSDisk == "grs"), | ||
| DBLrsStorage=dcountif(Name, OSDisk == "lrs"), | ||
| DBGeoStorage=dcountif(Name, OSDisk == "geo"), | ||
| DBLrsStorage=dcountif(Name, OSDisk != "geo"), |
Contributor
There was a problem hiding this comment.
DBLrsStorage=dcountif(Name, OSDisk != "geo"),
This line counts non-geo which might include ZRS storage as well. Is it intended for LRS count?
Contributor
Author
There was a problem hiding this comment.
I checked the variable again, DBGeoStorage is currently used to calculate the SQL DB score and DBLrsStorage is not used anywhere.
// SQLDB - 4 checks // score = ("status" + "tier" + "storage acct. type" + "AZ")* 100 / (5 * ResourceTotal) //********* Future - "read replica count"
Type == 'microsoft.sql/servers/databases', (DBOnlineStateCount + SqlPremiumOrBusinessCriticalOrDwh + DBGeoStorage + AvZoneCount + NAAvZoneCount) * 100 / (4 * ResourceTotal),
So we can delete DBLrsStorage, but I'd like to keep it just in case.
Contributor
There was a problem hiding this comment.
line 16: 5 checks for cosmos
| "quote": "'", | ||
| "delimiter": ",", | ||
| "query": "resources\r\n| extend Environment = case(\r\ntags.Environment <> \"\", tags.Environment,\r\ntags.environment <> \"\", tags.environment,\r\ntags.Env <> \"\", tags.Env,\r\ntags.env <> \"\", tags.env,\r\ntolower(name) contains \"prod\", \"Production\",\r\ntolower(name) contains \"dev\", \"Development\",\r\ntolower(name) contains \"qa\", \"QA\",\r\ntolower(name) contains \"uat\", \"UAT\",\r\ntolower(name) contains \"sit\", \"SIT\",\r\ntolower(name) contains \"test\", \"Test\",\r\n\"Undefined\")\r\n| distinct Environment", | ||
| "query": "resources\r\n| extend Environment = case(\r\ntags.Environment <> \"\", replace(\"\\\\\\\\\", \"<Backslash>\", tostring(tags.Environment)),\r\ntags.environment <> \"\", replace(\"\\\\\\\\\", \"<Backslash>\", tostring(tags.environment)),\r\ntags.Env <> \"\", replace(\"\\\\\\\\\", \"<Backslash>\", tostring(tags.Env)),\r\ntags.env <> \"\", replace(\"\\\\\\\\\", \"<Backslash>\", tostring(tags.env)),\r\ntolower(name) contains \"prod\", \"Production\",\r\ntolower(name) contains \"dev\", \"Development\",\r\ntolower(name) contains \"qa\", \"QA\",\r\ntolower(name) contains \"uat\", \"UAT\",\r\ntolower(name) contains \"sit\", \"SIT\",\r\ntolower(name) contains \"test\", \"Test\",\r\n\"Undefined\")\r\n| distinct Environment", |
Contributor
There was a problem hiding this comment.
Any reason we have to escape 8 backslashes?
Contributor
Author
There was a problem hiding this comment.
I got stuck in the same place.🙃
This is a query in Workbook JSON, so escaping is doubly necessary.
So, replace(\"\\\\\\\\\", is the same as replace("\\\\",.
Contributor
infosatheesh2020
left a comment
infosatheesh2020
left a comment
There was a problem hiding this comment.
Added few inline comments
infosatheesh2020
approved these changes
Apr 15, 2024
Contributor
Author
|
close #160 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.