Skip to content

Conversation

cataggar
Copy link
Member

@cataggar cataggar commented Aug 10, 2022

Fix #996. Twoazure_identity::token_credentials now require an Arc<dyn HttpClient>

  • ClientSecretCredential
  • EnvironmentCredential

The HttpClient is used to implement the oauth2 http client.

Tested with:

  • cargo run -p azure_security_keyvault --example get_secret_versions
  • cargo run -p azure_security_keyvault --example list_secrets

@cataggar cataggar marked this pull request as ready for review August 15, 2022 22:33
@cataggar cataggar requested review from bmc-msft and rylev August 15, 2022 22:33
rylev
rylev previously requested changes Aug 16, 2022
Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just have some code quality comments.

@cataggar cataggar dismissed rylev’s stale review August 17, 2022 12:43

@rylev, all your requested changes were made.

Copy link
Contributor

@rylev rylev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was a little hesitant to merge this since I think things could change considerably if/when we move to using a pipeline, but this is an improvement over the status quo, so I think we should land it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

implement oauth2 HTTP client

4 participants