-
Notifications
You must be signed in to change notification settings - Fork 314
implement oauth2 HTTP client #997
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sdk/identity/src/token_credentials/client_secret_credentials.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just have some code quality comments.
@rylev, all your requested changes were made.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was a little hesitant to merge this since I think things could change considerably if/when we move to using a pipeline, but this is an improvement over the status quo, so I think we should land it.
Fix #996. Two
azure_identity::token_credentials
now require anArc<dyn HttpClient>
ClientSecretCredential
EnvironmentCredential
The
HttpClient
is used to implement the oauth2 http client.Tested with: