allow wasm32 for azure_identity
#995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cataggar
changed the title
cataggar
commented
Aug 10, 2022
| mock_transport = { path = "../../eng/test/mock_transport" } | ||
|
|
||
| [features] | ||
| default = ["enable_reqwest", "azure_identity/default"] |
There was a problem hiding this comment.
azure_identity is a dev-dependency, so this doesn't work. It fails when publishing.
| [dependencies] | ||
| async-trait = "0.1" | ||
| azure_core = { path = "../core", version = "0.4" } | ||
| azure_identity = { path = "../identity", default_features = false } |
There was a problem hiding this comment.
azure_identity should be a dev-dependency.
This was referenced Aug 10, 2022
|
I'd prefer to merge this and then back out the changes once #996 is fixed. |
rylev
approved these changes
Aug 12, 2022
roeap
pushed a commit
to roeap/azure-sdk-for-rust
that referenced
this pull request
Aug 18, 2022
* make oauth2 an internal dependency of identity * stub out oauth2_async_http_client * add but headers * fix after merge * oauth2::http * str * move adapter into mod * examples cleanup * remove #[cfg(feature = "enable_reqwest")] from Azure#995 * set headers and body * address feedback Co-authored-by: Cameron Taggart <cameron.taggart@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes all of these checks to work:
The storage_blobs & storage_datalake dependency changes were included in yesterday's release.