Skip to content

Fix servicebus metadata #3396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix servicebus metadata #3396

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f1ce19e
Add error logging when a service has no publishable packages
danieljurek Dec 4, 2025
b490a94
Set publishing=true in servicebus Cargo.toml
danieljurek Dec 4, 2025
0c4cd29
Update sdk/servicebus/azure_messaging_servicebus/Cargo.toml
danieljurek Dec 4, 2025
c66391e
Keep publish = false
danieljurek Dec 4, 2025
0816de6
Instead of checking publish = false, exclude only packages that have …
danieljurek Dec 4, 2025
5b61fd8
Review feedback: LogWarning instead of LogError (neither will affect …
danieljurek Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions eng/scripts/Language-Settings.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,12 +44,21 @@ function Get-AllPackageInfoFromRepo ([string] $ServiceDirectory) {
$searchPath = Join-Path $searchPath $ServiceDirectory -Resolve
}

# when a package is marked `publish = false` in the Cargo.toml, `cargo metadata` returns an empty array for
# `publish`, otherwise it returns null. We only want to include packages where `publish` is null.
# Enumerate packages that do not have "test" as an independent word in the
# name.
# Examples:
# "azure_core" - included
# "azure_core_test" - excluded
# "azure_attestation" - included
$packages = Invoke-LoggedCommand "cargo metadata --format-version 1 --no-deps" -GroupOutput
| ConvertFrom-Json -AsHashtable
| Select-Object -ExpandProperty packages
| Where-Object { $_.manifest_path.StartsWith($searchPath) -and $null -eq $_.publish }
| Where-Object { $_.manifest_path.StartsWith($searchPath) -and "test" -notin ($_.name -split '_') }

if (!$packages) {
LogWarning "No publishable packages found in service directory: $ServiceDirectory"
return @()
}

$packageManifests = @{}
foreach ($package in $packages) {
Expand Down Expand Up @@ -120,7 +129,7 @@ function Get-AllPackageInfoFromRepo ([string] $ServiceDirectory) {
function Get-rust-AdditionalValidationPackagesFromPackageSet ($packagesWithChanges, $diff, $allPackageProperties) {
# if the change was in a service directory, but not in a package directory, test all the packages in the service directory
[array]$serviceFiles = ($diff.ChangedFiles + $diff.DeletedFiles) | ForEach-Object { $_ -replace '\\', '/' } | Where-Object { $_ -match "^sdk/.+/" }

# remove files that target any specific package
foreach ($package in $allPackageProperties) {
$packagePathPattern = "^$( [Regex]::Escape($package.DirectoryPath.Replace('\', '/')) )/"
Expand Down
Loading