Fix servicebus metadata #3396
Open
Fix servicebus metadata #3396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danieljurek
requested review from
LarryOsterman,
RickWinter,
heaths and
ronniegeraghty
as code owners
Copilot finished reviewing on behalf of
danieljurek
December 4, 2025 18:12
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a build and test pipeline issue where the servicebus package was being excluded from automation due to having publish = false in its Cargo.toml, causing the pipeline to fail when no publishable packages were found in the service directory.
Key Changes:
- Changed
publish = falsetopublish = truein the servicebus Cargo.toml to make the package discoverable by the build system - Added defensive error handling in the PowerShell script to log when no publishable packages are found
- Cleaned up trailing whitespace in the PowerShell script
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/servicebus/azure_messaging_servicebus/Cargo.toml | Changed package from non-publishable to publishable, allowing it to be included in build and test pipelines |
| eng/scripts/Language-Settings.ps1 | Added error logging when no publishable packages are found and removed trailing whitespace |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
RickWinter
requested changes
Dec 4, 2025
heaths
requested changes
Dec 4, 2025
…"test" as a differentiated part of the name
…control flow, but an empty list of packages might not be an error)
heaths
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get-GetAllPackageInfoFromRepo returns an empty array if no packages are publishable. This means there are no packages in the service to build and test which causes an error.
To fix: set
publish = truein theazure_messaging_servicebusCargo.toml file.Example build: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=5638463&view=logs&j=8be16720-14eb-5bbb-1134-7a8b2c5000bc&t=98f58421-5e68-5db5-4107-79c932a43ba0