fix the mypy invocation to properly error in and out of CI

eng/tox/run_mypy.py

@@ -62,25 +62,24 @@
     except CalledProcessError as src_err:
         src_code_error = src_err
 
-    if in_ci():
-        if not is_check_enabled(args.target_package, "type_check_samples", True):
+    if in_ci() and not is_check_enabled(args.target_package, "type_check_samples", True):
+        logging.info(
+            f"Package {package_name} opts-out of mypy check on samples."
+        )
+    else:
+        sample_code = [
+            *commands,
+            "--check-untyped-defs",
+            "--follow-imports=silent",
+            os.path.join(args.target_package, "samples")
+        ]
+        try:
             logging.info(
-                f"Package {package_name} opts-out of mypy check on samples."
+                f"Running mypy commands on sample code: {sample_code}"
             )
-        else:
-            sample_code = [
-                *commands,
-                "--check-untyped-defs",
-                "--follow-imports=silent",
-                os.path.join(args.target_package, "samples")
-            ]
-            try:
-                logging.info(
-                    f"Running mypy commands on sample code: {sample_code}"
-                )
-                check_call(sample_code)
-            except CalledProcessError as sample_err:
-                sample_code_error = sample_err
+            check_call(sample_code)
+        except CalledProcessError as sample_err:
+            sample_code_error = sample_err
 
     print("See https://aka.ms/python/typing-guide for information.\n\n")
     if src_code_error and sample_code_error:

tools/azure-sdk-tools/ci_tools/environment_exclusions.py

@@ -348,8 +348,6 @@
 ]
 
 
-
-
 def is_check_enabled(package_path: str, check: str, default: bool = True) -> bool:
     """
     Single-use function to evaluate whether or not a given check should run against a package.
@@ -381,7 +379,7 @@ def is_check_enabled(package_path: str, check: str, default: bool = True) -> boo
     # now pull the new pyproject.toml configuration
     config = get_config_setting(package_path, check.strip().lower(), True)
 
-    return (config and enabled)
+    return config and enabled
 
 
 def filter_tox_environment_string(namespace_argument: str, package_path: str) -> str:
@@ -395,8 +393,6 @@ def filter_tox_environment_string(namespace_argument: str, package_path: str) ->
     if package_path.endswith("setup.py"):
         package_path = os.path.dirname(package_path)
 
-    package_name = os.path.basename(package_path)
-
     if namespace_argument:
         tox_envs = namespace_argument.strip().split(",")
         filtered_set = []