Local tox checks do not skip
#28612
Merged
Local tox checks do not skip
#28612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scbedd
added
the
Central-EngSys
ghost
added
the
scbedd
commented
Feb 2, 2023
|
API change check API changes are not detected in this pull request. |
… which tox environments they are skipping
kristapratico
approved these changes
Feb 7, 2023
mccoyp
approved these changes
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #28550
tl;dr if all the checks in a static analyze are skipped, we should skip that step entirely.
This PR:
run_<check>scripts to always run locally, regardless of whether or not a package is ignored. You can get the same behavior as CI by populating environment variableTF_BUILD.Detailed description:
The job yaml itself supports some global level skips. We can take advantage of this feature by placing a script invocation at the beginning of the
Analyzebuild. This script should evaluate the packages of a service directory, and if all skip a given check that is also associated with a global skip (EG:Skip.Pylint), that variable will be automatically set.