Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Restore idle_time_before_shutdown property to Compute Instances #27551

Merged
merged 20 commits into from
Nov 19, 2022
Merged

[ML] Restore idle_time_before_shutdown property to Compute Instances #27551

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
440f653
Restored idle_time_before_shutdown property
nthandeMS Nov 16, 2022
18d2a98
Fixed unit tests for idle shutdown
nthandeMS Nov 16, 2022
59d5039
Merge branch 'main' into fix-breaking-change-idle-time
nthandeMS Nov 16, 2022
6080cb9
Updated Changelog
nthandeMS Nov 16, 2022
6dc1608
Reformatted changed files with black
nthandeMS Nov 17, 2022
74cb960
Updated Changelog text
nthandeMS Nov 17, 2022
033b569
Added deprecation warning for idle_time_before_shutdown
nthandeMS Nov 17, 2022
3ed4b4f
Added deprecation warning to idle_time_before_shutdown
nthandeMS Nov 17, 2022
69b8756
Updated CHANGELOG text
nthandeMS Nov 17, 2022
61018c0
Fix for extra experimental tag
nthandeMS Nov 17, 2022
40f88e8
Revert "Fix for extra experimental tag"
nthandeMS Nov 17, 2022
cfad3ca
Merge branch 'main' into fix-breaking-change-idle-time
nthandeMS Nov 17, 2022
aec6f2f
Merge branch 'main' into fix-breaking-change-idle-time
nthandeMS Nov 17, 2022
2cc8694
Reformatted deprecation warning
nthandeMS Nov 17, 2022
bbe3c51
Updated Changelog to pass check
nthandeMS Nov 18, 2022
5b3150a
Updated CHANGELOG dates
nthandeMS Nov 18, 2022
1be443a
Removed Changelog dates
nthandeMS Nov 18, 2022
ee32307
Updated version to 1.1.2 for Changelog verification
nthandeMS Nov 18, 2022
2838493
Update sdk/ml/azure-ai-ml/azure/ai/ml/entities/_compute/compute_insta…
nthandeMS Nov 18, 2022
2014732
Pylint fixes
nthandeMS Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Reformatted deprecation warning
  • Loading branch information
@nthandeMS
nthandeMS committed Nov 17, 2022
commit 2cc869495a7575302fc46a99937e68580765a4d3
5 changes: 3 additions & 2 deletions sdk/ml/azure-ai-ml/azure/ai/ml/entities/_compute/compute_instance.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,8 +246,9 @@ def _to_rest_object(self) -> ComputeResource:
if self.idle_time_before_shutdown_minutes:
idle_time_before_shutdown = f"PT{self.idle_time_before_shutdown_minutes}M"
elif self.idle_time_before_shutdown:
module_logger.warning(
"Property 'idle_time_before_shutdown': This property is deprecated. Please use 'idle_time_before_shutdown_minutes' instead."
warnings.warn(
"This property is deprecated",
nthandeMS marked this conversation as resolved.
Show resolved Hide resolved
DeprecationWarning
)
idle_time_before_shutdown = self.idle_time_before_shutdown
annatisch marked this conversation as resolved.
Show resolved Hide resolved

Expand Down