[ML] Restore idle_time_before_shutdown property to Compute Instances #27551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nthandeMS
requested review from
paulshealy1,
singankit,
diondrapeck,
luigiw,
harneetvirk,
kdestin,
MilesHolland and
needuv
as code owners
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
This reverts commit 61018c0.
annatisch
reviewed
Nov 17, 2022
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_compute/compute_instance.py
Outdated
Show resolved
Hide resolved
needuv
approved these changes
Nov 17, 2022
annatisch
reviewed
Nov 18, 2022
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_compute/compute_instance.py
Outdated
Show resolved
Hide resolved
…nce.py Co-authored-by: Anna Tisch <antisch@microsoft.com>
nthandeMS
added a commit
to nthandeMS/azure-sdk-for-python
that referenced
this pull request
Nov 19, 2022
…zure#27551) * Restored idle_time_before_shutdown property
nthandeMS
added a commit
that referenced
this pull request
Nov 21, 2022
* [ML] Disable sdk telemetry logging (#27603) * Disable sdk telemetry logging * [ML] Restore idle_time_before_shutdown property to Compute Instances (#27551) * Restored idle_time_before_shutdown property * Removed merge conflict * Removed extra change to init file Co-authored-by: Diondra <16376603+diondrapeck@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Restores the
idle_time_before_shutdownproperty to the Compute Instance class. This property is now deprecated in favor ofidle_time_before_shutdown_minutes.idle_time_before_shutdown: [ML] Updated parameter name to be idle_time_before_shutdown_minutes #26898idle_time_before_shutdown_minutesproperty would prevent the creation of Compute Instances when set to None.Removes an experimental decorator from Compute Schedules to match the rest of the class.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines