-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[formrecognizer] test cleanup #18830
Conversation
@@ -295,8 +295,8 @@ def test_invoice_multipage_pdf(self, client): | |||
|
|||
@FormRecognizerPreparer() | |||
@GlobalClientPreparer() | |||
def test_invoice_pdf_include_field_elements(self, client): | |||
with open(self.invoice_pdf, "rb") as fd: | |||
def test_invoice_jpg_include_field_elements(self, client): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
out of curiosity, why are you changing pdf tests to jpg?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Switching to the sample that the service team provided which actually returns all the fields for invoices. It's a jpg; we still have tests that test the pdf form.
@@ -198,8 +198,7 @@ def test_identity_document_jpg(self, client): | |||
# check dict values | |||
self.assertEqual(id_document.fields.get("LastName").value, "TALBOT") | |||
self.assertEqual(id_document.fields.get("FirstName").value, "LIAM R.") | |||
# FIXME service error when reading the license number returns 'LICWDLACD5DG' | |||
# self.assertEqual(id_document.fields.get("DocumentNumber").value, "WDLABCD456DG") | |||
self.assertEqual(id_document.fields.get("DocumentNumber").value, "WDLABCD456DG") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
glad to see this is fixed!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Review request for Microsoft.ContainerService to add version 2022-04-02-preview (Azure#18900) * Adds base for updating Microsoft.ContainerService from version preview/2022-03-02-preview to version 2022-04-02-preview * Updates readme * Updates API version in new specs and examples * update readme (Azure#18714) * add NetworkPluginMode to ManagedCluster (Azure#18735) * add NetworkPluginMode to ManagedCluster * add overlay example * remove example * only keep overlap as option * Add properties for apiserver-vnet-integration (Azure#18705) * Update for AKS trusted access feature (Azure#18708) * Update for AKS trusted access feature * fixup! Update for AKS trusted access feature * fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * OSSKU supports Windows options (Azure#18706) * OSSKU supports Windows options * Add example Create Agent Pool with Windows OSSKU * Improve description about the default value * Improve the description to clarify * Improve description about default Windows OSSKU * add storageProfile into managedcluster (Azure#18817) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * capatalize NetworkPluginMode name (Azure#18884) * capatalize NetworkPluginMode name * capitalize in description * aks: add enableCustomCATrust in v20220402-preview api-version (Azure#18830) * aks: add enableCustomCATrust in v20220402-preview api-version * aks: add description of CustomCATrust * aks: fix typo, add DaemonSet to custom words list Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com> * [AKS] Update on trustedaccess resource (Azure#18947) * Add paging for trusted access * update async state * fixup! update async state * Use enum for TrustedAccessRoleBinding's ProvisioningState (Azure#18950) Co-authored-by: Tyler Lloyd <tyler.lloyd@microsoft.com> Co-authored-by: gossion <guwe@microsoft.com> Co-authored-by: Dong Liu <doliu@microsoft.com> Co-authored-by: Shiqian Tao <62196586+ShiqianTao@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com> Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
Resolves #18642 #14300