[formrecognizer] test cleanup #18830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kristapratico
requested review from
catalinaperalta and
iscai-msft
as code owners
iscai-msft
approved these changes
May 20, 2021
| @@ -295,8 +295,8 @@ def test_invoice_multipage_pdf(self, client): | |||
|
|
|||
| @FormRecognizerPreparer() | |||
| @GlobalClientPreparer() | |||
| def test_invoice_pdf_include_field_elements(self, client): | |||
| with open(self.invoice_pdf, "rb") as fd: | |||
| def test_invoice_jpg_include_field_elements(self, client): | |||
There was a problem hiding this comment.
out of curiosity, why are you changing pdf tests to jpg?
There was a problem hiding this comment.
Switching to the sample that the service team provided which actually returns all the fields for invoices. It's a jpg; we still have tests that test the pdf form.
| @@ -198,8 +198,7 @@ def test_identity_document_jpg(self, client): | |||
| # check dict values | |||
| self.assertEqual(id_document.fields.get("LastName").value, "TALBOT") | |||
| self.assertEqual(id_document.fields.get("FirstName").value, "LIAM R.") | |||
| # FIXME service error when reading the license number returns 'LICWDLACD5DG' | |||
| # self.assertEqual(id_document.fields.get("DocumentNumber").value, "WDLABCD456DG") | |||
| self.assertEqual(id_document.fields.get("DocumentNumber").value, "WDLABCD456DG") | |||
There was a problem hiding this comment.
glad to see this is fixed!
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
May 10, 2022
Review request for Microsoft.ContainerService to add version 2022-04-02-preview (Azure#18900) * Adds base for updating Microsoft.ContainerService from version preview/2022-03-02-preview to version 2022-04-02-preview * Updates readme * Updates API version in new specs and examples * update readme (Azure#18714) * add NetworkPluginMode to ManagedCluster (Azure#18735) * add NetworkPluginMode to ManagedCluster * add overlay example * remove example * only keep overlap as option * Add properties for apiserver-vnet-integration (Azure#18705) * Update for AKS trusted access feature (Azure#18708) * Update for AKS trusted access feature * fixup! Update for AKS trusted access feature * fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * OSSKU supports Windows options (Azure#18706) * OSSKU supports Windows options * Add example Create Agent Pool with Windows OSSKU * Improve description about the default value * Improve the description to clarify * Improve description about default Windows OSSKU * add storageProfile into managedcluster (Azure#18817) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * capatalize NetworkPluginMode name (Azure#18884) * capatalize NetworkPluginMode name * capitalize in description * aks: add enableCustomCATrust in v20220402-preview api-version (Azure#18830) * aks: add enableCustomCATrust in v20220402-preview api-version * aks: add description of CustomCATrust * aks: fix typo, add DaemonSet to custom words list Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com> * [AKS] Update on trustedaccess resource (Azure#18947) * Add paging for trusted access * update async state * fixup! update async state * Use enum for TrustedAccessRoleBinding's ProvisioningState (Azure#18950) Co-authored-by: Tyler Lloyd <tyler.lloyd@microsoft.com> Co-authored-by: gossion <guwe@microsoft.com> Co-authored-by: Dong Liu <doliu@microsoft.com> Co-authored-by: Shiqian Tao <62196586+ShiqianTao@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com> Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18642 #14300