[ServiceBus] GA AMQPAnnotatedMessage #18705

yunhaoling · 2021-05-13T12:06:28Z

Addressing issue: #18665

check-enforcer · 2021-05-13T21:02:31Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

…butes extractions

sdk/servicebus/azure-servicebus/CHANGELOG.md

yunhaoling · 2021-05-27T07:33:44Z

/azp run python - servicebus - tests

azure-pipelines · 2021-05-27T07:33:56Z

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling · 2021-05-27T14:55:45Z

/azp run python - servicebus - tests

azure-pipelines · 2021-05-27T14:55:57Z

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling · 2021-05-27T15:51:58Z

/azp run python - servicebus - tests

azure-pipelines · 2021-05-27T15:52:10Z

Azure Pipelines successfully started running 1 pipeline(s).

sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py

sdk/servicebus/azure-servicebus/azure/servicebus/amqp/_amqp_message.py

sdk/servicebus/azure-servicebus/samples/sync_samples/send_and_receive_amqp_annotated_message.py

yunhaoling · 2021-06-02T10:10:57Z

/azp run python - servicebus - tests

azure-pipelines · 2021-06-02T10:11:10Z

Azure Pipelines successfully started running 1 pipeline(s).

yunhaoling · 2021-06-02T12:15:14Z

/azp run python - servicebus - tests

azure-pipelines · 2021-06-02T12:15:27Z

Azure Pipelines successfully started running 1 pipeline(s).

annatisch

LGTM

sdk/servicebus/azure-servicebus/azure/servicebus/_common/utils.py

sdk/servicebus/azure-servicebus/azure/servicebus/amqp/__init__.py

yunhaoling · 2021-06-02T22:25:44Z

/azp run python - servicebus - tests

azure-pipelines · 2021-06-02T22:25:57Z

Azure Pipelines successfully started running 1 pipeline(s).

sdk/servicebus/azure-servicebus/azure/servicebus/amqp/_amqp_message.py

…riority

yunhaoling · 2021-06-03T15:31:41Z

/azp run python - servicebus - tests

azure-pipelines · 2021-06-03T15:31:53Z

Azure Pipelines successfully started running 1 pipeline(s).

Review request for Microsoft.ContainerService to add version 2022-04-02-preview (Azure#18900) * Adds base for updating Microsoft.ContainerService from version preview/2022-03-02-preview to version 2022-04-02-preview * Updates readme * Updates API version in new specs and examples * update readme (Azure#18714) * add NetworkPluginMode to ManagedCluster (Azure#18735) * add NetworkPluginMode to ManagedCluster * add overlay example * remove example * only keep overlap as option * Add properties for apiserver-vnet-integration (Azure#18705) * Update for AKS trusted access feature (Azure#18708) * Update for AKS trusted access feature * fixup! Update for AKS trusted access feature * fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! fixup! Update for AKS trusted access feature * OSSKU supports Windows options (Azure#18706) * OSSKU supports Windows options * Add example Create Agent Pool with Windows OSSKU * Improve description about the default value * Improve the description to clarify * Improve description about default Windows OSSKU * add storageProfile into managedcluster (Azure#18817) Signed-off-by: Ji An Liu <jiliu8@microsoft.com> * capatalize NetworkPluginMode name (Azure#18884) * capatalize NetworkPluginMode name * capitalize in description * aks: add enableCustomCATrust in v20220402-preview api-version (Azure#18830) * aks: add enableCustomCATrust in v20220402-preview api-version * aks: add description of CustomCATrust * aks: fix typo, add DaemonSet to custom words list Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com> * [AKS] Update on trustedaccess resource (Azure#18947) * Add paging for trusted access * update async state * fixup! update async state * Use enum for TrustedAccessRoleBinding's ProvisioningState (Azure#18950) Co-authored-by: Tyler Lloyd <tyler.lloyd@microsoft.com> Co-authored-by: gossion <guwe@microsoft.com> Co-authored-by: Dong Liu <doliu@microsoft.com> Co-authored-by: Shiqian Tao <62196586+ShiqianTao@users.noreply.github.com> Co-authored-by: Ji'an Liu <jiliu8@microsoft.com> Co-authored-by: Mikołaj Umański <mik.umanski@gmail.com> Co-authored-by: Mikolaj Umanski <mumanski@microsoft.com>

yunhaoling added 3 commits May 13, 2021 05:01

cherry pick and resolve conflicts

6c86a4f

cherry pick and resolve conflicts

d07679f

impl update

d73c6f1

ghost added the Service Bus label May 13, 2021

yunhaoling added 3 commits May 13, 2021 06:45

update docs and comments

939818c

impl update for setters on amqp annotated message

ecc6b27

update tests

7acbdff

yunhaoling added 5 commits May 25, 2021 14:09

minor updates

84d2129

update sb and sb received msg to depend on raw_amqp_message for attri…

0214480

…butes extractions

resolve conflict

01a78d1

more fixes

19fa42f

minor fix

0b9b4ff

yunhaoling marked this pull request as ready for review May 27, 2021 06:59

yunhaoling requested review from annatisch, rakshith91 and swathipil as code owners May 27, 2021 06:59

yunhaoling commented May 27, 2021

View reviewed changes

sdk/servicebus/azure-servicebus/CHANGELOG.md Outdated Show resolved Hide resolved

fix py2.7 **kwargs and pylint error

4f91dd3

yunhaoling added 2 commits May 27, 2021 07:03

fix mypy

d42e32d

fix footer

d7a8e78

fix async tests

31d3119

yunhaoling commented May 27, 2021

View reviewed changes

sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py Outdated Show resolved Hide resolved

swathipil reviewed May 27, 2021

View reviewed changes

update private ivar usage

f4126ec

yunhaoling closed this Jun 2, 2021

yunhaoling reopened this Jun 2, 2021

yunhaoling added 2 commits June 2, 2021 03:08

fix type hint on amqp annotated message

28f8aff

temporarily pull of sample link from readme

26ef182

update tests

274bfce

Azure deleted a comment from azure-pipelines bot Jun 2, 2021

annatisch reviewed Jun 2, 2021

View reviewed changes

sdk/servicebus/azure-servicebus/azure/servicebus/_common/utils.py Outdated Show resolved Hide resolved

sdk/servicebus/azure-servicebus/azure/servicebus/amqp/__init__.py Outdated Show resolved Hide resolved

yunhaoling added 4 commits June 2, 2021 11:43

rename AMQP* to Amqp*

2b01abb

update changelog

7ab12f7

internal refactor to avoide duplicate creation

080e61e

fix mypy

1b69942

yunhaoling requested review from annatisch and swathipil June 2, 2021 22:26

annatisch reviewed Jun 3, 2021

View reviewed changes

sdk/servicebus/azure-servicebus/azure/servicebus/amqp/_amqp_message.py Outdated Show resolved Hide resolved

annatisch approved these changes Jun 3, 2021

View reviewed changes

yunhaoling added 2 commits June 3, 2021 08:28

change order of the transformation to make ServiceBusMessage be the p…

453e0cc

…riority

remove doc for value error

cb3abb7

yunhaoling merged commit 4609245 into Azure:master Jun 3, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ServiceBus] GA AMQPAnnotatedMessage #18705

[ServiceBus] GA AMQPAnnotatedMessage #18705

yunhaoling commented May 13, 2021 •

edited

Loading

check-enforcer bot commented May 13, 2021

yunhaoling commented May 27, 2021

azure-pipelines bot commented May 27, 2021

yunhaoling commented May 27, 2021

azure-pipelines bot commented May 27, 2021

yunhaoling commented May 27, 2021

azure-pipelines bot commented May 27, 2021

yunhaoling commented Jun 2, 2021

azure-pipelines bot commented Jun 2, 2021

yunhaoling commented Jun 2, 2021

azure-pipelines bot commented Jun 2, 2021

annatisch left a comment

yunhaoling commented Jun 2, 2021

azure-pipelines bot commented Jun 2, 2021

yunhaoling commented Jun 3, 2021

azure-pipelines bot commented Jun 3, 2021

[ServiceBus] GA AMQPAnnotatedMessage #18705

[ServiceBus] GA AMQPAnnotatedMessage #18705

Conversation

yunhaoling commented May 13, 2021 • edited Loading

check-enforcer bot commented May 13, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

yunhaoling commented May 27, 2021

azure-pipelines bot commented May 27, 2021

yunhaoling commented May 27, 2021

azure-pipelines bot commented May 27, 2021

yunhaoling commented May 27, 2021

azure-pipelines bot commented May 27, 2021

yunhaoling commented Jun 2, 2021

azure-pipelines bot commented Jun 2, 2021

yunhaoling commented Jun 2, 2021

azure-pipelines bot commented Jun 2, 2021

annatisch left a comment

Choose a reason for hiding this comment

yunhaoling commented Jun 2, 2021

azure-pipelines bot commented Jun 2, 2021

yunhaoling commented Jun 3, 2021

azure-pipelines bot commented Jun 3, 2021

yunhaoling commented May 13, 2021 •

edited

Loading