Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tables] Misc client updates #18462

Merged
merged 10 commits into from
May 6, 2021
Merged

[Tables] Misc client updates #18462

merged 10 commits into from
May 6, 2021

Conversation

annatisch
Copy link
Member

@annatisch annatisch commented Apr 30, 2021 •
edited
Loading

Fixes #18464
Resolves a number of minor issues raised during the archboard review for tables:

  • Removes location_mode from the public API
  • Updates the ivar documentation on clients
  • Renames account_url to endpoint to be consistent across languages
  • Removes the select parameter from list/query tables.
  • Adds the select parameter to get_entity

@annatisch
Copy link
Member Author

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@check-enforcer
Copy link

check-enforcer bot commented May 3, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@annatisch
Copy link
Member Author

/azp run python - tables - tests

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@annatisch annatisch marked this pull request as ready for review May 5, 2021 18:31
seankane-msft
seankane-msft approved these changes May 5, 2021
View reviewed changes
Copy link
Member

@seankane-msft seankane-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two small comments, otherwise LGTM

sdk/tables/azure-data-tables/azure/data/tables/aio/_table_service_client_async.py Outdated Show resolved Hide resolved
sdk/tables/azure-data-tables/tests/test_table_cosmos_async.py Outdated Show resolved Hide resolved
@annatisch
Copy link
Member Author

/azp run python - tables - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@annatisch annatisch merged commit 7f22af5 into Azure:master May 6, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 7, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
a662818 
…into azure_purview_scanning

* 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits)
  [purview] add catalog client (Azure#17788)
  Add spellcheck for modified files (Azure#18496)
  [Container Registry] Update API for Beta 2 (Azure#18392)
  First version of Confidential Ledger Python SDK (Azure#17951)
  [llc] add quickstart (Azure#18537)
  [Storage][Fix]Copy source is redirecting (Azure#18577)
  [Tables] pre-release script (Azure#18505)
  Update changelogs (Azure#18575)
  [formrecognizer] Adding to_dict() on custom models (Azure#18402)
  Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509)
  Extend Check Enforcer timeout (Azure#18526)
  Core raw streaming (Azure#17920)
  hide secrets in mgmt sdk (Azure#18535)
  add filter samples for list methods (Azure#18480)
  Revert changes to SetDevVersion. (Azure#18555)
  add support for filtering/paging/sorting options for "list_**" methods (Azure#18302)
  [Tables] Misc client updates (Azure#18462)
  [EventHub&ServiceBus] Prepare for release (Azure#18527)
  [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519)
  [AppConfig] Fixing samples (Azure#18542)
  ...
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 7, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
ee40824 
…into agrifood_nspkg

* 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits)
  [purview] add catalog client (Azure#17788)
  Add spellcheck for modified files (Azure#18496)
  [Container Registry] Update API for Beta 2 (Azure#18392)
  First version of Confidential Ledger Python SDK (Azure#17951)
  [llc] add quickstart (Azure#18537)
  [Storage][Fix]Copy source is redirecting (Azure#18577)
  [Tables] pre-release script (Azure#18505)
  Update changelogs (Azure#18575)
  [formrecognizer] Adding to_dict() on custom models (Azure#18402)
  Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509)
  Extend Check Enforcer timeout (Azure#18526)
  Core raw streaming (Azure#17920)
  hide secrets in mgmt sdk (Azure#18535)
  add filter samples for list methods (Azure#18480)
  Revert changes to SetDevVersion. (Azure#18555)
  add support for filtering/paging/sorting options for "list_**" methods (Azure#18302)
  [Tables] Misc client updates (Azure#18462)
  [EventHub&ServiceBus] Prepare for release (Azure#18527)
  [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519)
  [AppConfig] Fixing samples (Azure#18542)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seankane-msft seankane-msft seankane-msft approved these changes

Assignees
No one assigned
Labels
Tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Tables] Archboard feedback
2 participants
@annatisch @seankane-msft