First version of Confidential Ledger Python SDK #17951

lynshi · 2021-04-09T22:02:24Z

No description provided.

lynshi · 2021-04-09T22:04:44Z

/azp run prepare-pipelines

azure-pipelines · 2021-04-09T22:04:54Z

Azure Pipelines successfully started running 1 pipeline(s).

check-enforcer · 2021-04-09T22:12:01Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

lynshi · 2021-04-09T22:42:13Z

/azp run python - confidentialledger - ci

azure-pipelines · 2021-04-09T22:42:18Z

No pipelines are associated with this pull request.

lynshi · 2021-04-09T22:46:55Z

/azp run python - confidentialledger - tests

azure-pipelines · 2021-04-09T22:47:06Z

Azure Pipelines successfully started running 1 pipeline(s).

lynshi · 2021-04-09T22:56:49Z

/check-enforcer evaluate

lynshi · 2021-04-09T23:04:14Z

/azp run python - confidentialledger - tests

azure-pipelines · 2021-04-09T23:04:26Z

Azure Pipelines successfully started running 1 pipeline(s).

iscai-msft

Looked mainly at the python code, mainly deferring to @johanste for the api surface.

Want to say @lynshi this is a wonderful and beautiful PR, can clearly tell you put a lot of effort into it. Everything looks very clean!

sdk/confidentialledger/azure-confidentialledger/CHANGELOG.md

sdk/confidentialledger/azure-confidentialledger/azure/confidentialledger/_client.py

...entialledger/azure/confidentialledger/_generated_identity/v0_1_preview/aio/_configuration.py

iscai-msft · 2021-04-13T15:32:20Z

one last nit: notice this is code is written on your fork's master branch. It's cleaner if you write the code on a non-master branch of your fork, so you can keep your own fork's master clean and the same as Azure's master

lynshi · 2021-04-14T22:33:50Z

/azp run python - confidentialledger - tests

azure-pipelines · 2021-04-14T22:34:01Z

Azure Pipelines successfully started running 1 pipeline(s).

tjprescott · 2021-04-19T16:19:47Z

Link to API View: https://apiview.dev/Assemblies/Review/b7abeb7876884e3aa42cf8784c3bdf8b

lynshi · 2021-04-19T21:34:46Z

/azp run python - confidentialledger - tests

azure-pipelines · 2021-04-19T21:34:56Z

Azure Pipelines successfully started running 1 pipeline(s).

lynshi · 2021-05-06T00:02:00Z

/azp run python - confidentialledger - ci

azure-pipelines · 2021-05-06T00:02:21Z

Azure Pipelines successfully started running 1 pipeline(s).

lynshi · 2021-05-06T18:21:46Z

/azp run python - confidentialledger - ci

azure-pipelines · 2021-05-06T18:22:05Z

Azure Pipelines successfully started running 1 pipeline(s).

lynshi · 2021-05-06T19:36:15Z

/azp run python - confidentialledger - ci

azure-pipelines · 2021-05-06T19:36:35Z

Azure Pipelines successfully started running 1 pipeline(s).

lynshi · 2021-05-06T19:58:11Z

/azp run python - confidentialledger - ci

azure-pipelines · 2021-05-06T19:58:31Z

Azure Pipelines successfully started running 1 pipeline(s).

lynshi · 2021-05-06T20:28:02Z

/azp run python - confidentialledger - ci

azure-pipelines · 2021-05-06T20:28:21Z

Azure Pipelines successfully started running 1 pipeline(s).

lynshi · 2021-05-06T22:36:26Z

/azp run python - confidentialledger - ci

azure-pipelines · 2021-05-06T22:36:44Z

Azure Pipelines successfully started running 1 pipeline(s).

…into azure_purview_scanning * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) [purview] add catalog client (Azure#17788) Add spellcheck for modified files (Azure#18496) [Container Registry] Update API for Beta 2 (Azure#18392) First version of Confidential Ledger Python SDK (Azure#17951) [llc] add quickstart (Azure#18537) [Storage][Fix]Copy source is redirecting (Azure#18577) [Tables] pre-release script (Azure#18505) Update changelogs (Azure#18575) [formrecognizer] Adding to_dict() on custom models (Azure#18402) Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509) Extend Check Enforcer timeout (Azure#18526) Core raw streaming (Azure#17920) hide secrets in mgmt sdk (Azure#18535) add filter samples for list methods (Azure#18480) Revert changes to SetDevVersion. (Azure#18555) add support for filtering/paging/sorting options for "list_**" methods (Azure#18302) [Tables] Misc client updates (Azure#18462) [EventHub&ServiceBus] Prepare for release (Azure#18527) [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519) [AppConfig] Fixing samples (Azure#18542) ...

…into agrifood_nspkg * 'master' of https://github.com/Azure/azure-sdk-for-python: (31 commits) [purview] add catalog client (Azure#17788) Add spellcheck for modified files (Azure#18496) [Container Registry] Update API for Beta 2 (Azure#18392) First version of Confidential Ledger Python SDK (Azure#17951) [llc] add quickstart (Azure#18537) [Storage][Fix]Copy source is redirecting (Azure#18577) [Tables] pre-release script (Azure#18505) Update changelogs (Azure#18575) [formrecognizer] Adding to_dict() on custom models (Azure#18402) Raise CredentialUnavailableError when CLI subprocess times out (Azure#18509) Extend Check Enforcer timeout (Azure#18526) Core raw streaming (Azure#17920) hide secrets in mgmt sdk (Azure#18535) add filter samples for list methods (Azure#18480) Revert changes to SetDevVersion. (Azure#18555) add support for filtering/paging/sorting options for "list_**" methods (Azure#18302) [Tables] Misc client updates (Azure#18462) [EventHub&ServiceBus] Prepare for release (Azure#18527) [Communication]: Updated communication connection strings to be consistent across packages and languages (Azure#18519) [AppConfig] Fixing samples (Azure#18542) ...

lynshi added 4 commits April 9, 2021 13:50

bring in working files

34f70d1

update pipeline files

0ba935b

changes from new template

9007b6d

pass tests

98a8628

lynshi requested review from danieljurek, lmazuel, mayurid and mitchdenny as code owners April 9, 2021 22:02

update changelog

59d1681

test Reader enum too

92eb437

iscai-msft reviewed Apr 13, 2021

View reviewed changes

address pr comments

50ffc10

new recordings

53c31d2

lynshi requested a review from benbp as a code owner April 19, 2021 20:41

no from e in python 2.7

94cf735

lynshi added 4 commits May 6, 2021 09:50

fix super for 2.7

c716de6

update readme

772f141

update comment

7c3ebae

fix test packaging

63d7468

lynshi added 4 commits May 6, 2021 11:46

update dependencies

d33a5bf

add pylint ignore

4686c71

fix for 2.7

eed0753

_generated folder

c88196e

pylint

4fcab9c

super-with-arguments not in pipeline pylint

86cc3e8

consume codegen changes

b42651a

lynshi added 3 commits May 7, 2021 10:55

update readme

809e602

fix typo

792abe7

change wording

e9b4960

lmazuel merged commit 0c8125f into Azure:master May 7, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

First version of Confidential Ledger Python SDK #17951

First version of Confidential Ledger Python SDK #17951

lynshi commented Apr 9, 2021

lynshi commented Apr 9, 2021

azure-pipelines bot commented Apr 9, 2021

check-enforcer bot commented Apr 9, 2021

lynshi commented Apr 9, 2021

azure-pipelines bot commented Apr 9, 2021

lynshi commented Apr 9, 2021

azure-pipelines bot commented Apr 9, 2021

lynshi commented Apr 9, 2021

lynshi commented Apr 9, 2021

azure-pipelines bot commented Apr 9, 2021

iscai-msft left a comment

iscai-msft commented Apr 13, 2021

lynshi commented Apr 14, 2021

azure-pipelines bot commented Apr 14, 2021

tjprescott commented Apr 19, 2021

lynshi commented Apr 19, 2021

azure-pipelines bot commented Apr 19, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

First version of Confidential Ledger Python SDK #17951

First version of Confidential Ledger Python SDK #17951

Conversation

lynshi commented Apr 9, 2021

lynshi commented Apr 9, 2021

azure-pipelines bot commented Apr 9, 2021

check-enforcer bot commented Apr 9, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

lynshi commented Apr 9, 2021

azure-pipelines bot commented Apr 9, 2021

lynshi commented Apr 9, 2021

azure-pipelines bot commented Apr 9, 2021

lynshi commented Apr 9, 2021

lynshi commented Apr 9, 2021

azure-pipelines bot commented Apr 9, 2021

iscai-msft left a comment

Choose a reason for hiding this comment

iscai-msft commented Apr 13, 2021

lynshi commented Apr 14, 2021

azure-pipelines bot commented Apr 14, 2021

tjprescott commented Apr 19, 2021

lynshi commented Apr 19, 2021

azure-pipelines bot commented Apr 19, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021

lynshi commented May 6, 2021

azure-pipelines bot commented May 6, 2021