Update document translation sample slug #17989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should they maybe all be updated? |
heaths
approved these changes
Apr 13, 2021
| @@ -5,7 +5,7 @@ languages: | |||
| products: | |||
| - azure | |||
| - azure-cognitive-services | |||
| - azure-document-translation | |||
| - azure-translator | |||
There was a problem hiding this comment.
I think this is probably a better choice than what I did in the .NET PR, but let's find out from the service team for sure. Ultimately, they should probably request a new one if they feel it worth it. The slugs do get pretty specific, so maybe not a bad idea.
I opened issues for all other services that had invalid slugs.
Yeah going to hold on merging until we hear back from @maririos |
iscai-msft
added a commit
that referenced
this pull request
Apr 15, 2021
…into protocol_base * 'master' of https://github.com/Azure/azure-sdk-for-python: (337 commits) [Container Registry] adding blurb about env vars to set (#17976) shared_requirements msrest verison update (#17938) Deprecate Azure-Synapse (#18027) add perf tests (#17519) Increment package version after release of azure-search-documents (#18017) [Communication]: Migrated python identity tests to use ARM template (#17890) [Container Registry] fixing up the test-resources-post script (#17883) [Communication]: Removed error code assertion from unauthorized phone number test (#17955) Add Conda Publishing (#17889) fix search fields (#18014) Sync eng/common directory with azure-sdk-tools for PR 1552 (#18011) [AppConfiguration] fix tests (#17917) updating generated code (#17874) Update document translation sample slug (#17989) update release date (#17988) [Communication] - SDK - Synced SMS and Phone Numbers shared folders (#17985) Remove unnecessary attribute access (#18007) [AutoRelease] t2-healthcareapis-2021-04-12-56802 (#17968) Revert retain. (#18004) Sync eng/common directory with azure-sdk-tools for PR 1553 (#18002) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.