Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update release date #17988

Merged
merged 3 commits into from
Apr 13, 2021
Merged

update release date #17988

merged 3 commits into from
Apr 13, 2021

Conversation

xiangyan99
Copy link
Member

No description provided.

@xiangyan99 xiangyan99 requested a review from rakshith91 April 12, 2021 22:58
@ghost ghost added the Search label Apr 12, 2021
kristapratico
kristapratico approved these changes Apr 13, 2021
View reviewed changes
Copy link
Member

@kristapratico kristapratico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks for doing that :)

@kristapratico
Copy link
Member

Sorry one last thing - we also need to include "page_type: sample" like this: https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/formrecognizer/azure-ai-formrecognizer/samples/README.md

@xiangyan99 xiangyan99 merged commit a14cebf into master Apr 13, 2021
@xiangyan99 xiangyan99 deleted the search_release_date branch April 13, 2021 16:09
iscai-msft added a commit that referenced this pull request Apr 15, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
3fd484f 
…into protocol_base

* 'master' of https://github.com/Azure/azure-sdk-for-python: (337 commits)
  [Container Registry] adding blurb about env vars to set (#17976)
  shared_requirements msrest verison update (#17938)
  Deprecate Azure-Synapse (#18027)
  add perf tests (#17519)
  Increment package version after release of azure-search-documents (#18017)
  [Communication]: Migrated python identity tests to use ARM template (#17890)
  [Container Registry] fixing up the test-resources-post script (#17883)
  [Communication]: Removed error code assertion from unauthorized phone number test (#17955)
  Add Conda Publishing (#17889)
  fix search fields (#18014)
  Sync eng/common directory with azure-sdk-tools for PR 1552 (#18011)
  [AppConfiguration] fix tests (#17917)
  updating generated code (#17874)
  Update document translation sample slug (#17989)
  update release date (#17988)
  [Communication] - SDK - Synced SMS and Phone Numbers shared folders (#17985)
  Remove unnecessary attribute access (#18007)
  [AutoRelease] t2-healthcareapis-2021-04-12-56802 (#17968)
  Revert retain. (#18004)
  Sync eng/common directory with azure-sdk-tools for PR 1553 (#18002)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kristapratico kristapratico kristapratico approved these changes

@rakshith91 rakshith91 Awaiting requested review from rakshith91

Assignees
No one assigned
Labels
Search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xiangyan99 @kristapratico