Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication chat preview4 #16905

Merged
merged 16 commits into from
Mar 3, 2021
Merged

Communication chat preview4 #16905

merged 16 commits into from
Mar 3, 2021

Commits on Feb 24, 2021

  1. [Communication] Generate identifier Models from new swagger (#16735)

    * Add generated chat code from new swagger
    
    * Change to use new generated code
    
    * Address PR Feedback
    
    * Remove CommunicationUserIdentifierModel in identity,phone number package
    sacheun authored and sarkar-rajarshi committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    59f3312 View commit details
    Browse the repository at this point in the history
  2. Check schema of the object to determine the type [preview4] (#16838)

    * Replace identifier with rawId
    
    * Change serilizer
    
    * Replace indentifier with rawId in test code
    
    * Sync models across modules
    
    * fix typo in serizliser
    
    * Rearrange imports
    
    * Replace rawId with raw_id
    
    * remove trailing newline
    
    Co-authored-by: turalf <tufarhad@microsoft.com>
    2 people authored and sarkar-rajarshi committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    3de22c5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    fa33c5e View commit details
    Browse the repository at this point in the history
  4. Chat - preview4 changes

    - CommunicationUserIdentifier models added
    - create_chat_thread - returns CreateChatThreadResult instead of ChatThreadClient
    - add_participant - docstring update AddChatParticipantsResult instead of None
    - add_participants - docstring update AddChatParticipantsResult instead of None
    sarkar-rajarshi committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    181af3a View commit details
    Browse the repository at this point in the history
  5. pylint-changes

    sarkar-rajarshi committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    0f19fdb View commit details
    Browse the repository at this point in the history
  6. pylint changes

    sarkar-rajarshi committed Feb 24, 2021
    Configuration menu
    Copy the full SHA
    8d55449 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2021

  1. Method signature changed for add_pariticipant and add_participants

    - add_participant - AddChatParticipantsResult -> tuple(ChatThreadParticipant, CommunicationError)
    - add_participants - AddChatParticipantsResult -> list(tuple(ChatThreadParticipant, CommunicationError))
    - unit tests modified as per signature change
    - CommunicationErrorResponseConverter added to cosolidate list(ChatThreadParticipant) and list(CommunicationError) into list(tuple(ChatThreadParticipant, CommunicationError))
    - e2e tests modified as per signature change
    sarkar-rajarshi committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    717eea9 View commit details
    Browse the repository at this point in the history
  2. CreateChatThreadResult modified to handle partial errors in batch cal…

    …ls with ease
    
    - CreateChatThreadResult -> attributes changed to
      - chat_thread -> ChatThread (no change)
      - Errors -> CreateChatThreadErrors -> list(tuple(ChatThreadParticipant, CommunicationError))
    - create_chat_thread -> `thread_participants` and `repeatability_request_id` changed to keyword arguments
    - Modify unit tests to capture method signature modifications
    - Modify e2e tests to capture method signature modifications
    sarkar-rajarshi committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    d5ed0cd View commit details
    Browse the repository at this point in the history
  3. pylint-changes

    sarkar-rajarshi committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    b308b7d View commit details
    Browse the repository at this point in the history
  4. pylint fixes

    sarkar-rajarshi committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    077f198 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    84eb4e2 View commit details
    Browse the repository at this point in the history
  6. test recordings added

    sarkar-rajarshi committed Feb 26, 2021
    Configuration menu
    Copy the full SHA
    4c3e684 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2021

  1. add_participant -> raises error

    - Update README.md with modified signature
    - Update samples with new method signatures
    - Add test to detect invalid instantiation of AccessToken
    - Minor documentation updates
    - Modify unit tests to capture method signature modifications
    - Modify e2e tests to capture method signature modifications
    sarkar-rajarshi committed Mar 1, 2021
    Configuration menu
    Copy the full SHA
    990cadb View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2021

  1. pylint fixes

    sarkar-rajarshi committed Mar 2, 2021
    Configuration menu
    Copy the full SHA
    5985f47 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d58ec47 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ad01aec View commit details
    Browse the repository at this point in the history