-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication chat preview4 #16905
Communication chat preview4 #16905
Commits on Feb 24, 2021
-
[Communication] Generate identifier Models from new swagger (#16735)
* Add generated chat code from new swagger * Change to use new generated code * Address PR Feedback * Remove CommunicationUserIdentifierModel in identity,phone number package
Configuration menu - View commit details
-
Copy full SHA for 59f3312 - Browse repository at this point
Copy the full SHA 59f3312View commit details -
Check schema of the object to determine the type [preview4] (#16838)
* Replace identifier with rawId * Change serilizer * Replace indentifier with rawId in test code * Sync models across modules * fix typo in serizliser * Rearrange imports * Replace rawId with raw_id * remove trailing newline Co-authored-by: turalf <tufarhad@microsoft.com>
Configuration menu - View commit details
-
Copy full SHA for 3de22c5 - Browse repository at this point
Copy the full SHA 3de22c5View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa33c5e - Browse repository at this point
Copy the full SHA fa33c5eView commit details -
- CommunicationUserIdentifier models added - create_chat_thread - returns CreateChatThreadResult instead of ChatThreadClient - add_participant - docstring update AddChatParticipantsResult instead of None - add_participants - docstring update AddChatParticipantsResult instead of None
Configuration menu - View commit details
-
Copy full SHA for 181af3a - Browse repository at this point
Copy the full SHA 181af3aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0f19fdb - Browse repository at this point
Copy the full SHA 0f19fdbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8d55449 - Browse repository at this point
Copy the full SHA 8d55449View commit details
Commits on Feb 26, 2021
-
Method signature changed for add_pariticipant and add_participants
- add_participant - AddChatParticipantsResult -> tuple(ChatThreadParticipant, CommunicationError) - add_participants - AddChatParticipantsResult -> list(tuple(ChatThreadParticipant, CommunicationError)) - unit tests modified as per signature change - CommunicationErrorResponseConverter added to cosolidate list(ChatThreadParticipant) and list(CommunicationError) into list(tuple(ChatThreadParticipant, CommunicationError)) - e2e tests modified as per signature change
Configuration menu - View commit details
-
Copy full SHA for 717eea9 - Browse repository at this point
Copy the full SHA 717eea9View commit details -
CreateChatThreadResult modified to handle partial errors in batch cal…
…ls with ease - CreateChatThreadResult -> attributes changed to - chat_thread -> ChatThread (no change) - Errors -> CreateChatThreadErrors -> list(tuple(ChatThreadParticipant, CommunicationError)) - create_chat_thread -> `thread_participants` and `repeatability_request_id` changed to keyword arguments - Modify unit tests to capture method signature modifications - Modify e2e tests to capture method signature modifications
Configuration menu - View commit details
-
Copy full SHA for d5ed0cd - Browse repository at this point
Copy the full SHA d5ed0cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for b308b7d - Browse repository at this point
Copy the full SHA b308b7dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 077f198 - Browse repository at this point
Copy the full SHA 077f198View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84eb4e2 - Browse repository at this point
Copy the full SHA 84eb4e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c3e684 - Browse repository at this point
Copy the full SHA 4c3e684View commit details
Commits on Mar 1, 2021
-
add_participant -> raises error
- Update README.md with modified signature - Update samples with new method signatures - Add test to detect invalid instantiation of AccessToken - Minor documentation updates - Modify unit tests to capture method signature modifications - Modify e2e tests to capture method signature modifications
Configuration menu - View commit details
-
Copy full SHA for 990cadb - Browse repository at this point
Copy the full SHA 990cadbView commit details
Commits on Mar 2, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5985f47 - Browse repository at this point
Copy the full SHA 5985f47View commit details -
Configuration menu - View commit details
-
Copy full SHA for d58ec47 - Browse repository at this point
Copy the full SHA d58ec47View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad01aec - Browse repository at this point
Copy the full SHA ad01aecView commit details