-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Communication] Generate identifier Models from new swagger #16735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the models from the shared folder of all packages
@@ -4,15 +4,17 @@ | |||
# license information. | |||
# -------------------------------------------------------------------------- | |||
|
|||
from .models import ( | |||
from .._generated.models import ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be moved out of the shared folder. The shared folder across all packages should be identical. Considering that we are removing the models from the shared folder, we should move this class to the non-shared part of the chat code as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Updated in new iteration.
* Add generated chat code from new swagger * Change to use new generated code * Address PR Feedback * Remove CommunicationUserIdentifierModel in identity,phone number package
* [Communication] Generate identifier Models from new swagger (#16735) * Add generated chat code from new swagger * Address PR Feedback * Remove CommunicationUserIdentifierModel in identity,phone number package * Check schema of the object to determine the type [preview4] (#16838) * Replace identifier with rawId * Change serilizer * Replace indentifier with rawId in test code * Sync models across modules * fix typo in serizliser * Rearrange imports * Replace rawId with raw_id * remove trailing newline Co-authored-by: turalf <tufarhad@microsoft.com> * preview4 changes made + unit tests fixed * Chat - preview4 changes - CommunicationUserIdentifier models added - create_chat_thread - returns CreateChatThreadResult instead of ChatThreadClient - add_participant - docstring update AddChatParticipantsResult instead of None - add_participants - docstring update AddChatParticipantsResult instead of None * pylint-changes * pylint changes * Method signature changed for add_pariticipant and add_participants - add_participant - AddChatParticipantsResult -> tuple(ChatThreadParticipant, CommunicationError) - add_participants - AddChatParticipantsResult -> list(tuple(ChatThreadParticipant, CommunicationError)) - unit tests modified as per signature change - CommunicationErrorResponseConverter added to cosolidate list(ChatThreadParticipant) and list(CommunicationError) into list(tuple(ChatThreadParticipant, CommunicationError)) - e2e tests modified as per signature change * CreateChatThreadResult modified to handle partial errors in batch calls with ease - CreateChatThreadResult -> attributes changed to - chat_thread -> ChatThread (no change) - Errors -> CreateChatThreadErrors -> list(tuple(ChatThreadParticipant, CommunicationError)) - create_chat_thread -> `thread_participants` and `repeatability_request_id` changed to keyword arguments - Modify unit tests to capture method signature modifications - Modify e2e tests to capture method signature modifications * pylint-changes * pylint fixes * README.md update + pylint fixes * test recordings added * add_participant -> raises error - Update README.md with modified signature - Update samples with new method signatures - Add test to detect invalid instantiation of AccessToken - Minor documentation updates - Modify unit tests to capture method signature modifications - Modify e2e tests to capture method signature modifications * pylint fixes * cls removed from docstring + update_topic async refactored * cls removed from docstring Co-authored-by: Sam Cheung <sacheu@microsoft.com> Co-authored-by: turalf <tural.ferhadov@gmail.com> Co-authored-by: turalf <tufarhad@microsoft.com>
* [Communication] Generate identifier Models from new swagger (#16735) * Add generated chat code from new swagger * Address PR Feedback * Remove CommunicationUserIdentifierModel in identity,phone number package * Check schema of the object to determine the type [preview4] (#16838) * Replace identifier with rawId * Change serilizer * Replace indentifier with rawId in test code * Sync models across modules * fix typo in serizliser * Rearrange imports * Replace rawId with raw_id * remove trailing newline Co-authored-by: turalf <tufarhad@microsoft.com> * preview4 changes made + unit tests fixed * Chat - preview4 changes - CommunicationUserIdentifier models added - create_chat_thread - returns CreateChatThreadResult instead of ChatThreadClient - add_participant - docstring update AddChatParticipantsResult instead of None - add_participants - docstring update AddChatParticipantsResult instead of None * pylint-changes * pylint changes * Method signature changed for add_pariticipant and add_participants - add_participant - AddChatParticipantsResult -> tuple(ChatThreadParticipant, CommunicationError) - add_participants - AddChatParticipantsResult -> list(tuple(ChatThreadParticipant, CommunicationError)) - unit tests modified as per signature change - CommunicationErrorResponseConverter added to cosolidate list(ChatThreadParticipant) and list(CommunicationError) into list(tuple(ChatThreadParticipant, CommunicationError)) - e2e tests modified as per signature change * CreateChatThreadResult modified to handle partial errors in batch calls with ease - CreateChatThreadResult -> attributes changed to - chat_thread -> ChatThread (no change) - Errors -> CreateChatThreadErrors -> list(tuple(ChatThreadParticipant, CommunicationError)) - create_chat_thread -> `thread_participants` and `repeatability_request_id` changed to keyword arguments - Modify unit tests to capture method signature modifications - Modify e2e tests to capture method signature modifications * pylint-changes * pylint fixes * README.md update + pylint fixes * test recordings added * add_participant -> raises error - Update README.md with modified signature - Update samples with new method signatures - Add test to detect invalid instantiation of AccessToken - Minor documentation updates - Modify unit tests to capture method signature modifications - Modify e2e tests to capture method signature modifications * pylint fixes * cls removed from docstring + update_topic async refactored * cls removed from docstring Co-authored-by: Sam Cheung <sacheu@microsoft.com> Co-authored-by: turalf <tural.ferhadov@gmail.com> Co-authored-by: turalf <tufarhad@microsoft.com> Co-authored-by: Sam Cheung <sacheu@microsoft.com> Co-authored-by: turalf <tural.ferhadov@gmail.com> Co-authored-by: turalf <tufarhad@microsoft.com>
[Maps Search] Update names based on APIView feedback for Preview 1.0 (Azure#16735) * Update names * Update names, Type by feedback
No description provided.