Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] remove settled property on PeekMessage and ReceivedMessage #12850

Merged
merged 1 commit into from
Aug 4, 2020
Merged

[ServiceBus] remove settled property on PeekMessage and ReceivedMessage #12850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/servicebus/azure-servicebus/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@
- Removed instance variable `header`.

* Removed several properties and instance variables on PeekMessage and ReceivedMessage.
- Removed proeprty `partition_id` on both type.
- Removed property `partition_id` on both type.
- Removed property `settled` on both type.
- Removed instance variable `received_timestamp_utc` on both type.
- Removed property `settled` on `PeekMessage`.
- Removed property `expired` on `ReceivedMessage`.
Expand Down
10 changes: 0 additions & 10 deletions sdk/servicebus/azure-servicebus/azure/servicebus/_common/message.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,16 +878,6 @@ def locked_until_utc(self):
self._expiry = utc_from_timestamp(expiry_in_seconds)
return self._expiry

@property
def settled(self):
# type: () -> bool
"""Whether the message has been settled.
This will aways be `True` for a message received using ReceiveAndDelete mode,
otherwise it will be `False` until the message is completed or otherwise settled.
:rtype: bool
"""
return self._settled


class ReceivedMessage(ReceivedMessageBase):
def _settle_message(
Expand Down