Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ServiceBus] remove settled property on PeekMessage and ReceivedMessage #12850

Merged
merged 1 commit into from
Aug 4, 2020
Merged

[ServiceBus] remove settled property on PeekMessage and ReceivedMessage #12850

merged 1 commit into from
Aug 4, 2020

Conversation

yunhaoling
Copy link
Contributor

@yunhaoling yunhaoling commented Jul 31, 2020 •
edited
Loading

we decided to remove the property in preview 5 and may bring it back as post-GA feature, see issue: #12849

@yunhaoling yunhaoling added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jul 31, 2020
@ghost
Copy link

ghost commented Jul 31, 2020

V

KieranBrantnerMagee
KieranBrantnerMagee approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@KieranBrantnerMagee KieranBrantnerMagee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending a livetest run that goes green, out of paranoia that my ctrl+f didn't find an instance of us using this in a test.

@yunhaoling
Copy link
Contributor Author

yunhaoling commented Aug 4, 2020 •
edited
Loading

/azp run python - servicebus - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling yunhaoling merged commit 138e5ec into Azure:master Aug 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KieranBrantnerMagee KieranBrantnerMagee KieranBrantnerMagee approved these changes

@annatisch annatisch Awaiting requested review from annatisch

@YijunXieMS YijunXieMS Awaiting requested review from YijunXieMS

Assignees
No one assigned
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yunhaoling @KieranBrantnerMagee