Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADLA] - [HOTFIX] - Adding an InnerError property to JobInnerError.cs #3796

Conversation

ro-joowan
Copy link
Contributor

@ro-joowan ro-joowan commented Oct 17, 2017

Description


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

@ro-joowan ro-joowan changed the title Ro joowan adl hotfix 3 0 2 inner error [ADLA] - [HOTFIX] - Adding an InnerError property to JobInnerError.cs Oct 17, 2017
@shahabhijeet
Copy link
Member

@azuresdkci test this please

@ro-joowan
Copy link
Contributor Author

@shahabhijeet Please note that I ran the following for both branches (Azure:adl-hotfix-3-0-2-inner-error and ro-joowan:ro-joowan-adl-hotfix-3-0-2-inner-error):

git reset --hard 20ceebb

@ro-joowan
Copy link
Contributor Author

ro-joowan commented Oct 18, 2017

@shahabhijeet Did the test fail because of the "git reset" above?

@shahabhijeet
Copy link
Member

@azuresdkci test this please

@shahabhijeet shahabhijeet merged commit d6cb242 into Azure:adl-hotfix-3-0-2-inner-error Oct 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants