[BUG FIX] - Making JobInnerError object recursively defined #3666

ro-joowan · 2017-09-06T17:43:49Z

Based on this PR: [ADLA] - [BUGFIX] - Adding an innerError field to the JobInnerError object recursively azure-rest-api-specs#1627
We are essentially adding one more property to the JobInnerError object (recursively) in order to capture the additional error information that's returned by the service
This added property was tested successfully by a team member
Two file changes are in a previous PR ([CODE REFACTOR] - Commenting out flaky test #3634): SubmitGetListCancelTest.json and DataLakeStoreClientTests.cs. I just needed to push this PR as soon as possible.

Description

This checklist is used to make sure that common guidelines for a pull request are followed.

I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code.
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK.

* This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA

* This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS

* I missed this file!

… into psSdkJson6

* Updating to the correct commit number: Azure/azure-rest-api-specs#1452

* Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code

… into psSdkJson6

More descriptive and fixing indent issue that was not addressed in the previous commit

More descriptive and fixing indent issue not addressed in a previous commit

Adding an important note about retrieving a list of jobs and accounts

… into psSdkJson6

* Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed.

* Adding this as a reminder to re-enable the test

… into psSdkJson6

* Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8

… into psSdkJson6

* Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however.

… into psSdkJson6

* Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now

* Based on this PR: Azure/azure-rest-api-specs#1627 * We are essentially adding one more property to the JobInnerError object (recursively) in order to capture the additional error information that's returned by the service * This added property has been tested successfully by a team member

msftclas · 2017-09-06T17:43:53Z

@ro-joowan,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

shahabhijeet · 2017-09-07T19:27:13Z

...alytics/Management.DataLake.Analytics/Customizations/DataLakeAnalyticsCustomizationHelper.cs

@@ -14,7 +14,7 @@ internal static class DataLakeAnalyticsCustomizationHelper
        /// This constant is used as the default package version to place in the user agent.
        /// It should mirror the package version in the project.json file.
        /// </summary>
-        internal const string PackageVersion = "3.1.1-preview";
+        internal const string PackageVersion = "3.1.2-preview";


@ro-joowan can you explain what is this package number and what project.json file are you referring to.

@shahabhijeet Couldn't find a project.json file in the src. Ben might be referring to the csproj file (https://github.com/ro-joowan/azure-sdk-for-net/blob/341b0bbea8d9110f2047f9d28150a4cc95ef34fc/src/SDKs/DataLake.Analytics/Management.DataLake.Analytics/Microsoft.Azure.Management.DataLake.Analytics.csproj).

This is one of the three places I've been told to update the version number -- the other place being in AssemblyInfo.cs

As for its purpose, I found this in here (https://github.com/ro-joowan/azure-sdk-for-net/blob/341b0bbea8d9110f2047f9d28150a4cc95ef34fc/src/SDKs/DataLake.Analytics/Management.DataLake.Analytics/Customizations/DataLakeAnalyticsAccountManagementClient.Customizations.cs):

/// <param name='userAgentAssemblyVersion'> /// Optional. The version string that should be sent in the user-agent header for all requests. The default is the current version of the SDK. /// </param>

It looks like this custom method is a way for the user to set the SDK version in the user agent.

@shahabhijeet And so this PackageVersion is used as the default SDK version in the event that the user does not provide a custom version (https://github.com/ro-joowan/azure-sdk-for-net/blob/psSdkJson6/src/SDKs/DataLake.Analytics/Management.DataLake.Analytics/Customizations/DataLakeAnalyticsCustomizationHelper.cs#L29)

Let's revisit this in the next release.
If the package version reflects what is in project.json (which is package version in csproj)
We do pass the Assembly File version in user Agent string, so how will this version be any different from the other?
Will allow now.

ro-joowan · 2017-09-11T23:42:48Z

@shahabhijeet Friendly ping on this :)

* Code gen for ADLA * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA * Code gen for ADLS * This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS * Code gen for ADLS (part 2) * I missed this file! * Code gen for ADL (part 3) * Updating to the correct commit number: Azure/azure-rest-api-specs#1452 * Update Azure Batch to 5.1.0 (Azure#3513) * Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519) * Do hydra to swagger specs migration for azure-sdk-for-net (Azure#3482) * Do hydra to swagger specs migration for azure-sdk-for-net * Fix build failed problem * update the assemblyinfo file with the updated version 2.6.0 * Revert "update the assemblyinfo file with the updated version 2.6.0" This reverts commit a33beb0. * Updata the AssemblyFileVersion to 2.6.0.0 * revert package version * Make project files concise. * Add Provider test case * update the pr with new tests with session records * remove extra code * Fix Batch changelog references (Azure#3517) * Fixing changelog.md * Fixing up changelog.md * [DataLake Analytics] Fixing changelog.md More descriptive and fixing indent issue that was not addressed in the previous commit * [DataLake Store] Fixing changelog.md More descriptive and fixing indent issue not addressed in a previous commit * [DataLake Analytics] Fixing changelog.md Adding an important note about retrieving a list of jobs and accounts * Revising custom Job Exists method * Ran into two regressions in JobOperationTests.cs * The custom Job Exists method is expecting a non-empty response body to validate non-existence. After speaking with a team member who implemented the service, I can no longer rely on this. Thus, I am removing the logic that checks for a non-empty response body. * Commenting out the test case for listing Jobs with a select parameter. This is currently being fixed. * Adding a TODO comment * Adding this as a reminder to re-enable the test * [CODE GEN] - Reverting readOnly for two fields * Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8 * [CODE GEN] - Updating the version (3.1.0 to 3.1.1) * [CODE REFACTOR] - Removing flaky test * Removing test case: DataLakeUploader_FreshFolderUploadDownload() * Note: In the near future, the custom ADLS Filesystem code will be replaced with a new SDK that has its own set of test cases. The account management side of ADLS will still remain, however. * [DOC] - Updating the changelog to describe 3.1.1-preview * [CODE REFACTOR] - Skipping flaky test * Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now * [BUG FIX] - Making JobInnerError object recursively defined * Based on this PR: Azure/azure-rest-api-specs#1627 * We are essentially adding one more property to the JobInnerError object (recursively) in order to capture the additional error information that's returned by the service * This added property has been tested successfully by a team member

ro-joowan and others added 29 commits July 24, 2017 15:23

Code gen for ADLA

853090a

* This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit is for ADLA

Code gen for ADLS

8a72cc4

* This change is mapped to this PR: Azure/azure-rest-api-specs#1429 * This commit for ADLS

Code gen for ADLS (part 2)

d0429b1

* I missed this file!

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

d97f093

… into psSdkJson6

Code gen for ADL (part 3)

0bbe518

* Updating to the correct commit number: Azure/azure-rest-api-specs#1452

Update Azure Batch to 5.1.0 (Azure#3513)

a01781f

Fixing publishing of symbols. Fixing issue# 3518 (Azure#3519)

3793362

Fix Batch changelog references (Azure#3517)

caba128

Merge branch 'psSdkJson6' into psSdkJson6

528d017

Fixing changelog.md

2b8907f

Fixing up changelog.md

c4593fb

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

ddb1ea6

… into psSdkJson6

[DataLake Analytics] Fixing changelog.md

ee186ba

More descriptive and fixing indent issue that was not addressed in the previous commit

[DataLake Store] Fixing changelog.md

75f6a49

More descriptive and fixing indent issue not addressed in a previous commit

[DataLake Analytics] Fixing changelog.md

deb131f

Adding an important note about retrieving a list of jobs and accounts

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

398f5b5

… into psSdkJson6

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

7c8a514

… into psSdkJson6

Adding a TODO comment

5eec416

* Adding this as a reminder to re-enable the test

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

b047658

… into psSdkJson6

[CODE GEN] - Reverting readOnly for two fields

d45f70b

* Code gen based on this very descriptive PR: Azure/azure-rest-api-specs@e33ebf8

[CODE GEN] - Updating the version (3.1.0 to 3.1.1)

0487521

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

7c1e6f0

… into psSdkJson6

[DOC] - Updating the changelog to describe 3.1.1-preview

f9b2727

Merge branch 'psSdkJson6' of https://github.com/Azure/azure-sdk-for-net…

69f1810

… into psSdkJson6

[CODE REFACTOR] - Skipping flaky test

c9e918e

* Skipping the flaky test as opposed to commenting it out * Also, I forgot to replace a SessionRecord file from last update, so I doing it now

msftclas added the cla-not-required label Sep 6, 2017

Merge branch 'psSdkJson6' into inner-error

341b0bb

shahabhijeet suggested changes Sep 7, 2017

View reviewed changes

shahabhijeet added the Changes Requested label Sep 7, 2017

Merge branch 'psSdkJson6' into inner-error

1699af5

shahabhijeet approved these changes Sep 13, 2017

View reviewed changes

shahabhijeet merged commit 7467c8a into Azure:psSdkJson6 Sep 13, 2017

ro-joowan deleted the inner-error branch September 13, 2017 19:07

This was referenced Oct 17, 2017

[ADLA] - [HOTFIX] - Adding an InnerError property to JobInnerError.cs #3795

Closed

[ADLA] - [HOTFIX] - Adding an InnerError property to JobInnerError.cs #3796

Merged

[ADLA - ADLS] - [HOTFIX] - InnerError and ProvisioningState Enum #3804

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUG FIX] - Making JobInnerError object recursively defined #3666

[BUG FIX] - Making JobInnerError object recursively defined #3666

ro-joowan commented Sep 6, 2017 •

edited

Loading

msftclas commented Sep 6, 2017

shahabhijeet Sep 7, 2017

ro-joowan Sep 7, 2017 •

edited

Loading

ro-joowan Sep 8, 2017

shahabhijeet Sep 13, 2017 •

edited

Loading

ro-joowan commented Sep 11, 2017

[BUG FIX] - Making JobInnerError object recursively defined #3666

[BUG FIX] - Making JobInnerError object recursively defined #3666

Conversation

ro-joowan commented Sep 6, 2017 • edited Loading

Description

General Guidelines

Testing Guidelines

SDK Generation Guidelines

msftclas commented Sep 6, 2017

shahabhijeet Sep 7, 2017

Choose a reason for hiding this comment

ro-joowan Sep 7, 2017 • edited Loading

Choose a reason for hiding this comment

ro-joowan Sep 8, 2017

Choose a reason for hiding this comment

shahabhijeet Sep 13, 2017 • edited Loading

Choose a reason for hiding this comment

ro-joowan commented Sep 11, 2017

ro-joowan commented Sep 6, 2017 •

edited

Loading

ro-joowan Sep 7, 2017 •

edited

Loading

shahabhijeet Sep 13, 2017 •

edited

Loading