[AzureMonitorExporter] refactor demo projects #31204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimothyMothra
requested review from
cijothomas,
reyang,
rajkumar-rangaraj and
vishweshbankwar
as code owners
|
API change check API changes are not detected in this pull request. |
vishweshbankwar
approved these changes
Sep 16, 2022
...OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo/Metrics/MetricDemo.cs
Show resolved
Hide resolved
...r.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo/Traces/TraceDemo.cs
Outdated
Show resolved
Hide resolved
rajkumar-rangaraj
approved these changes
Sep 16, 2022
TimothyMothra
changed the title
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
* refactor demo project * update comment * cleanup. added comments. removed Shutdown.
samsp-msft
reviewed
Feb 2, 2023
|
|
||
| var resourceBuilder = ResourceBuilder.CreateDefault().AddAttributes(resourceAttributes); | ||
|
|
||
| this.tracerProvider = Sdk.CreateTracerProviderBuilder() |
There was a problem hiding this comment.
Its confusing that the ActivityEnrichingProcessor() and ActivityFilteringProcessor() are part of this project and not the SDK. Given that there are links to just this file as a sample, I got lost trying to find these - especially as github search is somewhat broken these days,
There was a problem hiding this comment.
HI @samsp-msft, point taken. I'll bring this up with the team about making these more discoverable. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor demo project as was discussed here: #30860 (comment)
Changes
Future work: customization examples will be added to these directories to accompany public Documentation.
Program.csinto three new classes "LogDemo", "MetricDemo", and "TraceDemo".ActivityEnrichingProcessorandActivityFilteringProcessorto "Demo\Traces" directory.