-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure Monitor Exporter - Update Demo to include logs and metrics #30860
Merged
rajkumar-rangaraj
merged 6 commits into
Azure:main
from
rajkumar-rangaraj:rajrang/updateDemo
Sep 7, 2022
Merged
Azure Monitor Exporter - Update Demo to include logs and metrics #30860
rajkumar-rangaraj
merged 6 commits into
Azure:main
from
rajkumar-rangaraj:rajrang/updateDemo
Sep 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajkumar-rangaraj
requested review from
cijothomas,
reyang,
TimothyMothra and
vishweshbankwar
as code owners
August 31, 2022 20:09
API change check API changes are not detected in this pull request. |
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Outdated
Show resolved
Hide resolved
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Outdated
Show resolved
Hide resolved
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Outdated
Show resolved
Hide resolved
TimothyMothra
approved these changes
Sep 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cijothomas
reviewed
Sep 6, 2022
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Show resolved
Hide resolved
cijothomas
reviewed
Sep 7, 2022
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Show resolved
Hide resolved
cijothomas
reviewed
Sep 7, 2022
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Show resolved
Hide resolved
cijothomas
reviewed
Sep 7, 2022
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Outdated
Show resolved
Hide resolved
cijothomas
approved these changes
Sep 7, 2022
reyang
reviewed
Sep 7, 2022
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Show resolved
Hide resolved
reyang
reviewed
Sep 7, 2022
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Sep 7, 2022
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Sep 7, 2022
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Outdated
Show resolved
Hide resolved
reyang
reviewed
Sep 7, 2022
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Outdated
Show resolved
Hide resolved
reyang
requested changes
Sep 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please find my comments.
reyang
reviewed
Sep 7, 2022
...or.OpenTelemetry.Exporter/tests/Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing/Program.cs
Outdated
Show resolved
Hide resolved
vishweshbankwar
approved these changes
Sep 7, 2022
reyang
approved these changes
Sep 7, 2022
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
…re#30860) * Update Demo App * remove global from namespace. * PR feedback * PR feedback * order namespace * Remove dispose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Demo app to include Logs and Metrics
TODO
Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing
toAzure.Monitor.OpenTelemetry.Exporter.Demo
in next PR. CI may not like the new name and need to validate it seperately.