Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Monitor Exporter - Update Demo to include logs and metrics #30860

Merged
merged 6 commits into from
Sep 7, 2022

Conversation

rajkumar-rangaraj
Copy link
Contributor

Update Demo app to include Logs and Metrics

TODO

  • Project name has a Trace in it. Will rename the project from Azure.Monitor.OpenTelemetry.Exporter.Demo.Tracing to Azure.Monitor.OpenTelemetry.Exporter.Demo in next PR. CI may not like the new name and need to validate it seperately.

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Copy link
Contributor

@TimothyMothra TimothyMothra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please find my comments.

@rajkumar-rangaraj rajkumar-rangaraj merged commit c392b60 into Azure:main Sep 7, 2022
sofiar-msft pushed a commit to sofiar-msft/azure-sdk-for-net that referenced this pull request Dec 7, 2022
…re#30860)

* Update Demo App

* remove global from namespace.

* PR feedback

* PR feedback

* order namespace

* Remove dispose
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Monitor - Exporter Monitor OpenTelemetry Exporter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants