Compute 2022-07-02, 2022-08-01 changes #30536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haagha
requested review from
fengzhou-msft,
archerzz,
ArcturusZhang,
Yao725 and
ArthurMa1978
as code owners
ghost
added
the
Yao725
previously requested changes
Aug 18, 2022
There was a problem hiding this comment.
Where does these code changes come from? I don't see any metadata change here.
And one more important thing is, this is the track 1 SDK and we will deprecate it soon, please contact @ArthurMa1978 and provide the justification about this release.
* Added test for Performance Plus and Bursting enabled time. * Added test for Performance Plus and Bursting enabled time. * Added a session file Co-authored-by: akashpargat <akashpargat@microsoft.com>
* adding tests * updating disk tests * updating test name * updating test and adding session record * updating test for optimzeFrequentAttach * removing sas * updating gb * simplifying optimizedForFrequentAttach sceario * adding results to crud optimize test * updating global.json * removing comment * updating test
sdk/compute/Microsoft.Azure.Management.Compute/src/Customizations/SupportedCapabilities.cs
Outdated
Show resolved
Hide resolved
|
For compute we discussed with @ArthurMa1978 that track2 will be released. |
|
New Version increment is not needed for this PR now. @grizzlytheodore will add his changes and make changes for new release. |
sdk/compute/Microsoft.Azure.Management.Compute/src/Microsoft.Azure.Management.Compute.csproj
Show resolved
Hide resolved
...t.Compute/tests/SessionRecords/DiskRPScenarioTests/Disk_CRUD_WithSecurityProfile_Import.json
Outdated
Show resolved
Hide resolved
added 4 commits
September 20, 2022 23:29
sdk/compute/Microsoft.Azure.Management.Compute/src/Generated/Models/Disk.cs
Show resolved
Hide resolved
* feature branch set up for new version * set up branch * regenerate sdk with proper swagger updates * update recordings * mitigate rolling upgrade test * remove key * last test recording * last recordings * updated sdk tests (#30870) * Add property "priorityMixPolicy" of VM Scale Set to .NET SDK for Version 2022-08-01 (#30688) * Run code generation from Swagger Specs * Added custom constructor due to code generation changing the parameter order * Added and verified successful run of new test for PriorityMixPolicy property * more intuitive assertions in priorityMixPolicy test * moved most recent test recording to correct folder * Added parameter descriptions for Scale Set properties which did not have parameter descriptions in the file with custom VMSS constructors * ci failures popped up again after adding new parameter descriptions Co-authored-by: Alec Lawlor <aleclawlor@microsoft.com> * regenerated * update recording to resolve conflict * SDK changes for VMAgent Versioning + ProtectedSettings (#30395) * init * testing Co-authored-by: Theodore Chang <thchan@microsoft.com> * newly generated * generated * commit new-recorded jsons * add customization Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com> Co-authored-by: Alec Lawlor <43768045+aleclawlor@users.noreply.github.com> Co-authored-by: Alec Lawlor <aleclawlor@microsoft.com> Co-authored-by: kamusta-msft <56413142+kamusta-msft@users.noreply.github.com>
grizzlytheodore
changed the title
|
this is ready for merge @ArthurMa1978 @Yao725 |
ArthurMa1978
approved these changes
Sep 23, 2022
sofiar-msft
pushed a commit
to sofiar-msft/azure-sdk-for-net
that referenced
this pull request
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
This PR includes changes from
DiskRP version 2022-07-02: Azure/azure-rest-api-specs#20223
and ComputeRP versions 2022-08-01 Azure/azure-rest-api-specs#20552
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.