Add property "priorityMixPolicy" of VM Scale Set to .NET SDK for Version 2022-08-01 #30688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleclawlor
requested review from
fengzhou-msft,
archerzz,
ArcturusZhang,
Yao725 and
ArthurMa1978
as code owners
ghost
added
the
mlalic
reviewed
Aug 23, 2022
| @@ -78,6 +78,33 @@ public partial class VirtualMachineScaleSet : Resource | |||
| /// <param name="extendedLocation">The extended location of the Virtual | |||
| /// Machine Scale Set.</param> | |||
| /// | |||
added 2 commits
August 24, 2022 12:55
…ave parameter descriptions in the file with custom VMSS constructors
|
Hi CPlat SDK team. Just as an FYI: This PR initially had no ci failures as of commit 2a5570a. I then changed a single comment in one of the files (no code changes at all) and the ci failures came up again. Additionally, these ci failures seemingly have nothing to do with my changes. The branch this PR is based off of has the latest changes from the 2022-08-01 branch. I have messaged Theodore on the side about this but wanted to put it out here as well, as I know the .NET SDK merges are taking place soon. |
grizzlytheodore
added a commit
that referenced
this pull request
Sep 21, 2022
* feature branch set up for new version * set up branch * regenerate sdk with proper swagger updates * update recordings * mitigate rolling upgrade test * remove key * last test recording * last recordings * updated sdk tests (#30870) * Add property "priorityMixPolicy" of VM Scale Set to .NET SDK for Version 2022-08-01 (#30688) * Run code generation from Swagger Specs * Added custom constructor due to code generation changing the parameter order * Added and verified successful run of new test for PriorityMixPolicy property * more intuitive assertions in priorityMixPolicy test * moved most recent test recording to correct folder * Added parameter descriptions for Scale Set properties which did not have parameter descriptions in the file with custom VMSS constructors * ci failures popped up again after adding new parameter descriptions Co-authored-by: Alec Lawlor <aleclawlor@microsoft.com> * regenerated * update recording to resolve conflict * SDK changes for VMAgent Versioning + ProtectedSettings (#30395) * init * testing Co-authored-by: Theodore Chang <thchan@microsoft.com> * newly generated * generated * commit new-recorded jsons * add customization Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com> Co-authored-by: hari-bodicherla <43284966+hari-bodicherla@users.noreply.github.com> Co-authored-by: Alec Lawlor <43768045+aleclawlor@users.noreply.github.com> Co-authored-by: Alec Lawlor <aleclawlor@microsoft.com> Co-authored-by: kamusta-msft <56413142+kamusta-msft@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.