Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Network changes into AutoRest #2999

Merged
merged 39 commits into from
Mar 28, 2017
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
39 commits
Select commit Hold shift + click to select a range
dd1bf69
Virtual Network Gateway Connection tests for Ipsec Policy
henry416 Mar 13, 2017
af97a84
Generated code for network new 2017-03-01 api-version (only Ipsec Pol…
henry416 Mar 16, 2017
3e92d91
package version incremented
henry416 Mar 16, 2017
d8f24c6
#WAF added autogenerated files
jobatzil Mar 17, 2017
4d7bbbc
#WAF changed version in rest API calls of Network/SessionRecords.
jobatzil Mar 17, 2017
678613c
#WAF changed version in rest API calls of Compute/SessionRecords.
jobatzil Mar 17, 2017
c95c199
Merge remote-tracking branch 'upstream/AutoRest' into AutoRest
henry416 Mar 17, 2017
c8288be
#WAF set x-ms-flatten to true for ApplicationGatewayFirewallRuleSet.
jobatzil Mar 18, 2017
a245f83
Using proper rest api spec for 2017-03-01 generation
henry416 Mar 20, 2017
8aeba43
#WAF Added web application firewall related tests and rerecorded agw …
jobatzil Mar 21, 2017
86b2b89
#WAF removed unneccessary file ending changes created by the PS scrip…
jobatzil Mar 21, 2017
ae21523
#WAF updated comment for ApplicationGatewayFirewallDisabledRuleGroup.…
jobatzil Mar 21, 2017
91ea4b3
#WAF incremented assembly version.
jobatzil Mar 21, 2017
86f6cd3
Update Network test versions to 2017-03-01
henry416 Mar 21, 2017
9cac289
corrected Assembly version for 2017-03-01
henry416 Mar 21, 2017
35f83bd
#WAF removed redundancy in description of enums.
jobatzil Mar 21, 2017
354816e
#WAF updated required fields for getBackendHealth Api result.
jobatzil Mar 21, 2017
dce29a7
#INIT updated the api-version to 2016-03-01 in the Network *Operation…
jobatzil Mar 22, 2017
f916094
#INIT Updated Version number to 10.0.0 (next major version) since the…
jobatzil Mar 22, 2017
b0ec565
#INIT Changed version number to 2017-03-01 in Network/SessionRecordings.
jobatzil Mar 22, 2017
d6151b3
#INIT Changed version number to 2017-03-01 in Compute/SessionRecordings.
jobatzil Mar 22, 2017
34fd7c6
#INIT Removed unneccessary changes where only end of file chagned.
jobatzil Mar 22, 2017
ccbc38e
Merge remote-tracking branch 'upstream/network-changes' into AutoRest
henry416 Mar 22, 2017
05e52a9
AssemblyInfo revert AssemblyVersion to original as requested
henry416 Mar 22, 2017
4d44fec
#WAF Renamed GetAvailableWafRuleSets to ListAvailableWafRuleSets.
jobatzil Mar 22, 2017
89cd77f
Merge pull request #2958 from jobatzil/feature/jobatzil/waf
cormacpayne Mar 22, 2017
8af95e9
merge with network-changes branch
henry416 Mar 22, 2017
2108694
removed EOF-only changes
henry416 Mar 22, 2017
3704f56
Merge remote-tracking branch 'upstream/network-changes' into feature/…
jobatzil Mar 22, 2017
a007d57
Merge remote-tracking branch 'upstream/network-changes' into feature/…
jobatzil Mar 22, 2017
97c5852
Merge pull request #2943 from henry416/AutoRest
cormacpayne Mar 23, 2017
d9b1aa8
Merge remote-tracking branch 'upstream/network-changes' into feature/…
jobatzil Mar 23, 2017
ed4e0c0
Merge pull request #2976 from jobatzil/feature/jobatzil/plain201703
cormacpayne Mar 23, 2017
0baef6d
#12345: Updating generated files after fixing virtualNetworkGateway r…
Nilambari Mar 24, 2017
d51092b
#WAF improved tests.
jobatzil Mar 24, 2017
35bdd3f
Merge branch 'feature/jobatzil/plain201703' into feature/jobatzil/waf
jobatzil Mar 24, 2017
10b0785
#WAF Recorded new ApplicationGateway tests.
jobatzil Mar 27, 2017
502ca16
Merge pull request #2986 from Nilambari/network-changes
cormacpayne Mar 27, 2017
62bced7
Merge pull request #2992 from jobatzil/feature/jobatzil/waf2
cormacpayne Mar 28, 2017
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -525,10 +525,6 @@ internal LocalNetworkGatewaysOperations(NetworkManagementClient client)
{
throw new ValidationException(ValidationRules.CannotBeNull, "parameters");
}
if (parameters != null)
{
parameters.Validate();
}
if (Client.SubscriptionId == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "this.Client.SubscriptionId");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ public LocalNetworkGateway() { }
/// <summary>
/// Initializes a new instance of the LocalNetworkGateway class.
/// </summary>
/// <param name="localNetworkAddressSpace">Local network site address
/// space.</param>
/// <param name="id">Resource ID.</param>
/// <param name="name">Resource name.</param>
/// <param name="type">Resource type.</param>
/// <param name="location">Resource location.</param>
/// <param name="tags">Resource tags.</param>
/// <param name="localNetworkAddressSpace">Local network site address
/// space.</param>
/// <param name="gatewayIpAddress">IP address of local network
/// gateway.</param>
/// <param name="bgpSettings">Local network gateway's BGP speaker
Expand All @@ -50,7 +50,7 @@ public LocalNetworkGateway() { }
/// 'Deleting', and 'Failed'.</param>
/// <param name="etag">A unique read-only string that changes whenever
/// the resource is updated.</param>
public LocalNetworkGateway(AddressSpace localNetworkAddressSpace, string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), string gatewayIpAddress = default(string), BgpSettings bgpSettings = default(BgpSettings), string resourceGuid = default(string), string provisioningState = default(string), string etag = default(string))
public LocalNetworkGateway(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), AddressSpace localNetworkAddressSpace = default(AddressSpace), string gatewayIpAddress = default(string), BgpSettings bgpSettings = default(BgpSettings), string resourceGuid = default(string), string provisioningState = default(string), string etag = default(string))
: base(id, name, type, location, tags)
{
LocalNetworkAddressSpace = localNetworkAddressSpace;
Expand Down Expand Up @@ -100,19 +100,6 @@ public LocalNetworkGateway() { }
[JsonProperty(PropertyName = "etag")]
public string Etag { get; set; }

/// <summary>
/// Validate the object.
/// </summary>
/// <exception cref="ValidationException">
/// Thrown if validation fails
/// </exception>
public virtual void Validate()
{
if (LocalNetworkAddressSpace == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "LocalNetworkAddressSpace");
}
}
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,11 @@ public VirtualNetworkGateway() { }
/// <summary>
/// Initializes a new instance of the VirtualNetworkGateway class.
/// </summary>
/// <param name="id">Resource ID.</param>
/// <param name="name">Resource name.</param>
/// <param name="type">Resource type.</param>
/// <param name="location">Resource location.</param>
/// <param name="tags">Resource tags.</param>
/// <param name="ipConfigurations">IP configurations for virtual
/// network gateway.</param>
/// <param name="gatewayType">The type of this virtual network gateway.
Expand All @@ -40,11 +45,6 @@ public VirtualNetworkGateway() { }
/// <param name="vpnType">The type of this virtual network gateway.
/// Possible values are: 'PolicyBased' and 'RouteBased'. Possible
/// values include: 'PolicyBased', 'RouteBased'</param>
/// <param name="id">Resource ID.</param>
/// <param name="name">Resource name.</param>
/// <param name="type">Resource type.</param>
/// <param name="location">Resource location.</param>
/// <param name="tags">Resource tags.</param>
/// <param name="enableBgp">Whether BGP is enabled for this virtual
/// network gateway or not.</param>
/// <param name="activeActive">ActiveActive flag</param>
Expand All @@ -67,7 +67,7 @@ public VirtualNetworkGateway() { }
/// 'Deleting', and 'Failed'.</param>
/// <param name="etag">Gets a unique read-only string that changes
/// whenever the resource is updated.</param>
public VirtualNetworkGateway(IList<VirtualNetworkGatewayIPConfiguration> ipConfigurations, string gatewayType, string vpnType, string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), bool? enableBgp = default(bool?), bool? activeActive = default(bool?), SubResource gatewayDefaultSite = default(SubResource), VirtualNetworkGatewaySku sku = default(VirtualNetworkGatewaySku), VpnClientConfiguration vpnClientConfiguration = default(VpnClientConfiguration), BgpSettings bgpSettings = default(BgpSettings), string resourceGuid = default(string), string provisioningState = default(string), string etag = default(string))
public VirtualNetworkGateway(string id = default(string), string name = default(string), string type = default(string), string location = default(string), IDictionary<string, string> tags = default(IDictionary<string, string>), IList<VirtualNetworkGatewayIPConfiguration> ipConfigurations = default(IList<VirtualNetworkGatewayIPConfiguration>), string gatewayType = default(string), string vpnType = default(string), bool? enableBgp = default(bool?), bool? activeActive = default(bool?), SubResource gatewayDefaultSite = default(SubResource), VirtualNetworkGatewaySku sku = default(VirtualNetworkGatewaySku), VpnClientConfiguration vpnClientConfiguration = default(VpnClientConfiguration), BgpSettings bgpSettings = default(BgpSettings), string resourceGuid = default(string), string provisioningState = default(string), string etag = default(string))
: base(id, name, type, location, tags)
{
IpConfigurations = ipConfigurations;
Expand Down Expand Up @@ -168,41 +168,6 @@ public VirtualNetworkGateway() { }
[JsonProperty(PropertyName = "etag")]
public string Etag { get; set; }

/// <summary>
/// Validate the object.
/// </summary>
/// <exception cref="ValidationException">
/// Thrown if validation fails
/// </exception>
public virtual void Validate()
{
if (IpConfigurations == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "IpConfigurations");
}
if (GatewayType == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "GatewayType");
}
if (VpnType == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "VpnType");
}
if (IpConfigurations != null)
{
foreach (var element in IpConfigurations)
{
if (element != null)
{
element.Validate();
}
}
}
if (Sku != null)
{
Sku.Validate();
}
}
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -223,18 +223,6 @@ public virtual void Validate()
{
throw new ValidationException(ValidationRules.CannotBeNull, "ConnectionType");
}
if (VirtualNetworkGateway1 != null)
{
VirtualNetworkGateway1.Validate();
}
if (VirtualNetworkGateway2 != null)
{
VirtualNetworkGateway2.Validate();
}
if (LocalNetworkGateway2 != null)
{
LocalNetworkGateway2.Validate();
}
if (IpsecPolicies != null)
{
foreach (var element in IpsecPolicies)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,13 @@ public VirtualNetworkGatewayIPConfiguration() { }
/// Initializes a new instance of the
/// VirtualNetworkGatewayIPConfiguration class.
/// </summary>
/// <param name="subnet">The reference of the subnet resource.</param>
/// <param name="publicIPAddress">The reference of the public IP
/// resource.</param>
/// <param name="id">Resource ID.</param>
/// <param name="privateIPAllocationMethod">The private IP allocation
/// method. Possible values are: 'Static' and 'Dynamic'. Possible
/// values include: 'Static', 'Dynamic'</param>
/// <param name="subnet">The reference of the subnet resource.</param>
/// <param name="publicIPAddress">The reference of the public IP
/// resource.</param>
/// <param name="provisioningState">The provisioning state of the
/// public IP resource. Possible values are: 'Updating', 'Deleting',
/// and 'Failed'.</param>
Expand All @@ -47,7 +47,7 @@ public VirtualNetworkGatewayIPConfiguration() { }
/// resource.</param>
/// <param name="etag">A unique read-only string that changes whenever
/// the resource is updated.</param>
public VirtualNetworkGatewayIPConfiguration(SubResource subnet, SubResource publicIPAddress, string id = default(string), string privateIPAllocationMethod = default(string), string provisioningState = default(string), string name = default(string), string etag = default(string))
public VirtualNetworkGatewayIPConfiguration(string id = default(string), string privateIPAllocationMethod = default(string), SubResource subnet = default(SubResource), SubResource publicIPAddress = default(SubResource), string provisioningState = default(string), string name = default(string), string etag = default(string))
: base(id)
{
PrivateIPAllocationMethod = privateIPAllocationMethod;
Expand Down Expand Up @@ -99,23 +99,6 @@ public VirtualNetworkGatewayIPConfiguration() { }
[JsonProperty(PropertyName = "etag")]
public string Etag { get; set; }

/// <summary>
/// Validate the object.
/// </summary>
/// <exception cref="ValidationException">
/// Thrown if validation fails
/// </exception>
public virtual void Validate()
{
if (Subnet == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "Subnet");
}
if (PublicIPAddress == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "PublicIPAddress");
}
}
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ namespace Microsoft.Azure.Management.Network.Models
using Azure;
using Management;
using Network;
using Rest;
using Newtonsoft.Json;
using System.Linq;

Expand All @@ -37,7 +36,7 @@ public VirtualNetworkGatewaySku() { }
/// values include: 'Basic', 'HighPerformance', 'Standard',
/// 'UltraPerformance'</param>
/// <param name="capacity">The capacity.</param>
public VirtualNetworkGatewaySku(string name, string tier, int? capacity = default(int?))
public VirtualNetworkGatewaySku(string name = default(string), string tier = default(string), int? capacity = default(int?))
{
Name = name;
Tier = tier;
Expand Down Expand Up @@ -68,23 +67,6 @@ public VirtualNetworkGatewaySku() { }
[JsonProperty(PropertyName = "capacity")]
public int? Capacity { get; set; }

/// <summary>
/// Validate the object.
/// </summary>
/// <exception cref="ValidationException">
/// Thrown if validation fails
/// </exception>
public virtual void Validate()
{
if (Name == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "Name");
}
if (Tier == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "Tier");
}
}
}
}

Original file line number Diff line number Diff line change
Expand Up @@ -840,10 +840,6 @@ internal VirtualNetworkGatewaysOperations(NetworkManagementClient client)
{
throw new ValidationException(ValidationRules.CannotBeNull, "parameters");
}
if (parameters != null)
{
parameters.Validate();
}
if (Client.SubscriptionId == null)
{
throw new ValidationException(ValidationRules.CannotBeNull, "this.Client.SubscriptionId");
Expand Down