-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Network changes into AutoRest #2999
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added virtual network gateway connection tests for ipsec policies Added VirtualNetworkGatewayConnection Ipsec Policies Test record Test Cases updated to use field names Connection Ipsec Policies Test session data Ipsec policies Test added for virtual network gateway connections
…icies added compared to previous swagger)
…t for updating the api version number in SessionRecords.
…re will be breaking changes for application gateway.
#WAF Added the changes of web application firewall for application gateway
…jobatzil/plain201703
Ipsec Policies for Virtual Network Gateway Connection
…jobatzil/plain201703
#INIT to 2017-03-01
…esource swagger to remove unnecessary required params.
Updating generated files after fixing virtualNetworkGateway resource swagger to remove unnecessary required params.
#WAF Renamed getAvailableWafRuleSets to listAvailableWafRuleSets and enhanced tests.
henry416
approved these changes
Mar 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IPsec policy work is intact
Nilambari
approved these changes
Mar 28, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signing off for merge of PR:- #2986
@cormacpayne LGTM. Merge whenever you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Merging changes for Network version 10.0.0-preview back into the AutoRest branch.
@jobatzil @Nilambari @henry416 please take a look
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
Testing Guidelines
SDK Generation Guidelines
project.json
andAssemblyInfo.cs
files have been updated with the new version of the SDK.