Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default storage location #26494

Merged
merged 10 commits into from
Jan 24, 2022
Merged

Conversation

vishweshbankwar
Copy link
Contributor

@vishweshbankwar vishweshbankwar commented Jan 20, 2022

  • Adds StorageFolder as option to provide location for saving telemetry offline.
  • If StorageFolder is not provided then following default base locations will be used:

For Windows:

  • %LOCALAPPDATA%\Microsoft\ApplicationInsights
  • %TEMP%\Microsoft\ApplicationInsights

For NonWindows:

  • %TMPDIR%/Microsoft/ApplicationInsights
  • /var/tmp/Microsoft/ApplicationInsights
  • /tmp/Microsoft/ApplicationInsights

Open Question:

  1. Should we use same folder location for traces/logs/metrics or separate folder for each (e.g. %LOCALAPPDATA%\Microsoft\ApplicationInsights\traces, %LOCALAPPDATA%\Microsoft\ApplicationInsights\metrics).
  • Having separate location for each type will result in offline telemetry transmitted by their respective exporters. TraceExporter will not be able to transmit telemetry stored offline by MetricExporter.

NOTE:: Using this default base location, a subdirectory will be created by persistent storage based on application.
E.g.
Telemetry for AppA will be stored in %LOCALAPPDATA%\Microsoft\ApplicationInsights\aedb383c9dd16b651394c322cf3c5eafccd12daf81246dd930e905661a8c4edd

and AppB will be stored in
%LOCALAPPDATA%\Microsoft\ApplicationInsights\abdcc83c9dd16b6cbdbbd1246dd930e905661a8c4edd

TODO;
Add tests
Add security for directory in windows

Copy link
Member

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vishweshbankwar vishweshbankwar merged commit ea75aaf into main Jan 24, 2022
@vishweshbankwar vishweshbankwar deleted the vibankwa/default-storage-for-telemetry branch January 24, 2022 20:23
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Nov 8, 2023
Release network microsoft.network official 2023 06 01 (Azure#26218)

* Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01

* Updates readme

* Updates API version in new specs and examples

* Add missing DeleteBastionShareableLinkByToken API back to swagger (Azure#25599)

* add DeleteBastionShareableLinkByToken endpoint
* fix location link format

* Adding Developer Sku (Azure#25887)

* Firewall Policy - IDPS profiles (Azure#25666)

* add profile to put example

* fixed RuleCollectionGroupWithHttpHeadersToInsert example

* add profile to Policy model

* description change

* indentation

* ListIdpsSignatures description change

* direction description+enum fix

* fix FirewallPolicyIDPSSignatureSeverity description

* hostnames for l4 listeners (Azure#25982)

* added ergwscale support (Azure#25969)

* Fixed examples for gateway load balancer (Azure#26058)

* Add support for JSChallenge action in Application Gateway Web application Firewall (Azure#26149)

* Add support for JSChallenge action

Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules

* Update WafPolicyGet.json

* Update WafPolicyCreateOrUpdate.json

* DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (Azure#26248)

* fixes

* making changes in new api version

---------

Co-authored-by: Manas Chakka <manaschakka@microsoft.com>

* [NVA] Internet Ingress Parameters (Azure#26262)

* [NVA] Internet Ingress Parameters

* LintDiff Fix

* Minor Fix

* Added description for each of the enums for ApplicationGatewayProtocol (Azure#26437)

* Added description for each of the enums for ApplicationGatewayProtocol

* Spacing for prettier checks

* Remove routingConfigNfv (Azure#25962)

* remove routingConfigNfv

* remove api from older versions

* remove PUT nvaconnection from older versions

* apply prettier check

* add suppression for modelValidation

* remove suppression due to approval

* Fix lint errors & add supressions (Azure#26494)

* fix lint error

* add supression for ResourceNameRestriction & LroErrorContent

* fix example accordingly

---------

Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
Co-authored-by: Sijie Lin <97983749+msftsijielin@users.noreply.github.com>
Co-authored-by: anvrao1 <109107918+anvrao1@users.noreply.github.com>
Co-authored-by: NiviShenker <99583088+NiviShenker@users.noreply.github.com>
Co-authored-by: gdhillon24 <105729965+gdhillon24@users.noreply.github.com>
Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com>
Co-authored-by: irrogozh <irrogozh@microsoft.com>
Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com>
Co-authored-by: Manas Chakka <mchakka@gmail.com>
Co-authored-by: Manas Chakka <manaschakka@microsoft.com>
Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com>
Co-authored-by: rutuja-s <42910715+rutuja-s@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Nov 8, 2023
Release network microsoft.network official 2023 06 01 (Azure#26218)

* Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01

* Updates readme

* Updates API version in new specs and examples

* Add missing DeleteBastionShareableLinkByToken API back to swagger (Azure#25599)

* add DeleteBastionShareableLinkByToken endpoint
* fix location link format

* Adding Developer Sku (Azure#25887)

* Firewall Policy - IDPS profiles (Azure#25666)

* add profile to put example

* fixed RuleCollectionGroupWithHttpHeadersToInsert example

* add profile to Policy model

* description change

* indentation

* ListIdpsSignatures description change

* direction description+enum fix

* fix FirewallPolicyIDPSSignatureSeverity description

* hostnames for l4 listeners (Azure#25982)

* added ergwscale support (Azure#25969)

* Fixed examples for gateway load balancer (Azure#26058)

* Add support for JSChallenge action in Application Gateway Web application Firewall (Azure#26149)

* Add support for JSChallenge action

Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules

* Update WafPolicyGet.json

* Update WafPolicyCreateOrUpdate.json

* DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (Azure#26248)

* fixes

* making changes in new api version

---------

Co-authored-by: Manas Chakka <manaschakka@microsoft.com>

* [NVA] Internet Ingress Parameters (Azure#26262)

* [NVA] Internet Ingress Parameters

* LintDiff Fix

* Minor Fix

* Added description for each of the enums for ApplicationGatewayProtocol (Azure#26437)

* Added description for each of the enums for ApplicationGatewayProtocol

* Spacing for prettier checks

* Remove routingConfigNfv (Azure#25962)

* remove routingConfigNfv

* remove api from older versions

* remove PUT nvaconnection from older versions

* apply prettier check

* add suppression for modelValidation

* remove suppression due to approval

* Fix lint errors & add supressions (Azure#26494)

* fix lint error

* add supression for ResourceNameRestriction & LroErrorContent

* fix example accordingly

---------

Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com>
Co-authored-by: Sijie Lin <97983749+msftsijielin@users.noreply.github.com>
Co-authored-by: anvrao1 <109107918+anvrao1@users.noreply.github.com>
Co-authored-by: NiviShenker <99583088+NiviShenker@users.noreply.github.com>
Co-authored-by: gdhillon24 <105729965+gdhillon24@users.noreply.github.com>
Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com>
Co-authored-by: irrogozh <irrogozh@microsoft.com>
Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com>
Co-authored-by: Manas Chakka <mchakka@gmail.com>
Co-authored-by: Manas Chakka <manaschakka@microsoft.com>
Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com>
Co-authored-by: rutuja-s <42910715+rutuja-s@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants