-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Anomaly Detector] CodeGen #25982
[Anomaly Detector] CodeGen #25982
Conversation
API changes have been detected in |
The focus of these changes is to regenerate code based on the v1.1-preview.1 version of the swagger.
d845485
to
97a861b
Compare
Add samples and tests for preview 1.1
@jsquire I've seen some checks still not successful for this PR and no reviewer approved. Is there any other things need me to do? Or you will help cover following things before merge? |
Hi @mengaims. There are still issues that need to be addressed. To echo what I reported on the email thread:
I don't have much context around this package, but since it's under an |
change release date in changelog
@jsquire Thanks for your comments! |
Anomoly/codegen
@mengaims: I merged your updates in. Unless you made additional changes to the API surface by regenerating the code, you shouldn't need to export the API again - I did that after generating and it's included here. We'll see if something gets cranky during CI. So long as CI passes, you're free to sign off on this PR and we'll get things merged into With respect to resolving the breaking changes and resolving the issues with the
I honestly have no idea. |
@mengaims: Looks like CI is happy. Please feel free to approve at your convenience and I'll get things merged in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved for preview
Release network microsoft.network official 2023 06 01 (Azure#26218) * Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * Add missing DeleteBastionShareableLinkByToken API back to swagger (Azure#25599) * add DeleteBastionShareableLinkByToken endpoint * fix location link format * Adding Developer Sku (Azure#25887) * Firewall Policy - IDPS profiles (Azure#25666) * add profile to put example * fixed RuleCollectionGroupWithHttpHeadersToInsert example * add profile to Policy model * description change * indentation * ListIdpsSignatures description change * direction description+enum fix * fix FirewallPolicyIDPSSignatureSeverity description * hostnames for l4 listeners (Azure#25982) * added ergwscale support (Azure#25969) * Fixed examples for gateway load balancer (Azure#26058) * Add support for JSChallenge action in Application Gateway Web application Firewall (Azure#26149) * Add support for JSChallenge action Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules * Update WafPolicyGet.json * Update WafPolicyCreateOrUpdate.json * DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (Azure#26248) * fixes * making changes in new api version --------- Co-authored-by: Manas Chakka <manaschakka@microsoft.com> * [NVA] Internet Ingress Parameters (Azure#26262) * [NVA] Internet Ingress Parameters * LintDiff Fix * Minor Fix * Added description for each of the enums for ApplicationGatewayProtocol (Azure#26437) * Added description for each of the enums for ApplicationGatewayProtocol * Spacing for prettier checks * Remove routingConfigNfv (Azure#25962) * remove routingConfigNfv * remove api from older versions * remove PUT nvaconnection from older versions * apply prettier check * add suppression for modelValidation * remove suppression due to approval * Fix lint errors & add supressions (Azure#26494) * fix lint error * add supression for ResourceNameRestriction & LroErrorContent * fix example accordingly --------- Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com> Co-authored-by: Sijie Lin <97983749+msftsijielin@users.noreply.github.com> Co-authored-by: anvrao1 <109107918+anvrao1@users.noreply.github.com> Co-authored-by: NiviShenker <99583088+NiviShenker@users.noreply.github.com> Co-authored-by: gdhillon24 <105729965+gdhillon24@users.noreply.github.com> Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: Manas Chakka <mchakka@gmail.com> Co-authored-by: Manas Chakka <manaschakka@microsoft.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: rutuja-s <42910715+rutuja-s@users.noreply.github.com>
Release network microsoft.network official 2023 06 01 (Azure#26218) * Adds base for updating Microsoft.Network from version stable/2023-05-01 to version 2023-06-01 * Updates readme * Updates API version in new specs and examples * Add missing DeleteBastionShareableLinkByToken API back to swagger (Azure#25599) * add DeleteBastionShareableLinkByToken endpoint * fix location link format * Adding Developer Sku (Azure#25887) * Firewall Policy - IDPS profiles (Azure#25666) * add profile to put example * fixed RuleCollectionGroupWithHttpHeadersToInsert example * add profile to Policy model * description change * indentation * ListIdpsSignatures description change * direction description+enum fix * fix FirewallPolicyIDPSSignatureSeverity description * hostnames for l4 listeners (Azure#25982) * added ergwscale support (Azure#25969) * Fixed examples for gateway load balancer (Azure#26058) * Add support for JSChallenge action in Application Gateway Web application Firewall (Azure#26149) * Add support for JSChallenge action Add support for JSChallenge action in the list of supported actions for Custom rules and Managed rules * Update WafPolicyGet.json * Update WafPolicyCreateOrUpdate.json * DDoS - Fixing Swagger Validation Issues on DDoSCustomPolicy (Azure#26248) * fixes * making changes in new api version --------- Co-authored-by: Manas Chakka <manaschakka@microsoft.com> * [NVA] Internet Ingress Parameters (Azure#26262) * [NVA] Internet Ingress Parameters * LintDiff Fix * Minor Fix * Added description for each of the enums for ApplicationGatewayProtocol (Azure#26437) * Added description for each of the enums for ApplicationGatewayProtocol * Spacing for prettier checks * Remove routingConfigNfv (Azure#25962) * remove routingConfigNfv * remove api from older versions * remove PUT nvaconnection from older versions * apply prettier check * add suppression for modelValidation * remove suppression due to approval * Fix lint errors & add supressions (Azure#26494) * fix lint error * add supression for ResourceNameRestriction & LroErrorContent * fix example accordingly --------- Co-authored-by: htippanaboya <102244326+htippanaboya@users.noreply.github.com> Co-authored-by: Sijie Lin <97983749+msftsijielin@users.noreply.github.com> Co-authored-by: anvrao1 <109107918+anvrao1@users.noreply.github.com> Co-authored-by: NiviShenker <99583088+NiviShenker@users.noreply.github.com> Co-authored-by: gdhillon24 <105729965+gdhillon24@users.noreply.github.com> Co-authored-by: aneeshakella-microsoft <109654329+aneeshakella-microsoft@users.noreply.github.com> Co-authored-by: irrogozh <irrogozh@microsoft.com> Co-authored-by: ssevugan21 <122578291+ssevugan21@users.noreply.github.com> Co-authored-by: Manas Chakka <mchakka@gmail.com> Co-authored-by: Manas Chakka <manaschakka@microsoft.com> Co-authored-by: JainRah <108508612+JainRah@users.noreply.github.com> Co-authored-by: rutuja-s <42910715+rutuja-s@users.noreply.github.com>
Summary
The focus of these changes is to regenerate code based on the v1.1-preview.1 version of the swagger.