Fix mgmt storage tests #25425
Merged
Fix mgmt storage tests #25425
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [x] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [x] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [x] Pull request includes test coverage for the included changes.
Increment package version after release of Microsoft.Azure.OperationalInsights
* Generate changes before any transforms * Regenerate code after adding transforms * Update internal interface and cleanup removed properties * Update public API * Update service version and test session records * Fix params for `ExchangeAadAccessTokenForAcrRefreshToken()` Set `GrantType` as `AccessToken`. `tenant` and `refreshToken` are null. * Update public API * Update session records * Update Changelog
* update docker-start-proxy to have a slightly different default parameter * we were surrounding the value in single quotes, breaking recording load Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com>
The focus of these changes is to stabilize some tests with non-deterministic behavior that have recently shown to be flaky when run in CI pipelines.
# Summary The focus of these changes is to enhance the logging section of the diagnostics sample to include details about the lifetime of the `AzureEventSourceListener`. We received some customer feedback that it was unclear where they needed to create the listener and that it had to have the appropriate scope to be able to capture logs.
* add test for AddPolicy * share proposed refactoring to HttpPipelineExtensions * ideas in the direction of implementation * mark retry policy * revert mark retry policy * shifting API around * experiment with using MemoryPool * use ArrayPool * use ArrayPool * add tests * update API * throw if didn't use pipeline builder * pr feedback and merge follow-up * pr fb and merge follow-up * pr fb * simplify request pipeline creation * move AddPolicy tests to Core; pr fb * nit * pr fb * pr fb & fix build * pr fb * pr fb & build fix * pr fb * pr fb * pr fb & fix core ci
* use main branch * generated for 2021-12-01 API * switch AvsTests to test mock_api server * Updating recorded test files also tested with playback * generate from main * set to 3.0.0 * Updating test records for AVS/2021-12 * Updating new test records * Updated test records Co-authored-by: Pinak Kelkar <pinakkelkar@microsoft.com>
* Generated new code from 06-preview version * Regenerated code to pick up additional changes. * Update unit tests for 2021-06-01-preview and SystemData * updated metadata * Updated package version to 4.0.0-preview.1 Co-authored-by: Soohwan Kim <sookim@microsoft.com> Co-authored-by: Jiacheng Liu <jiachengliu@microsoft.com>
Increment package version after release of Azure.Containers.ContainerRegistry
* add tests from track1 * add and modify some tests add tests modify tests * ignore PITR test case * ignore PrivateEndpointConnection tests
* [Event Hubs] Sample updates for the Buffered Producer The focus of these changes is to incorporate the `EventHubBufferedProducer` client into the Event Hubs samples for client types and publishing. Also included is a clarification for the logging sample, calling out the lifetime needs for the listener.
…25032) * Add Anycast parameter to GetRelayConfiguration * Update PR, removing unused snippet. * Modified swagger, so adding new autogenerated code * Update PR * Update PR, add new recordings, reenable non-identity tests * Adding GetRelayOptions and updating Readme and changelog * Update PR * Update PR
… in AnomalyAlertConfigurationLiveTests and AnomalyDetectionConfigurationLiveTests (#24540)
* Rename LLC to Dataplane Code Gen
The focus of these changes is to trim some unused logic for enqueuing events, add some missing mock setups to guard against a test race, and improve some minor test structure.
merge main storage tests
ghost
added
yukun-dong
requested review from
AlexGhiondea,
ArthurMa1978,
JoshLove-msft,
Kishp01,
KrzysztofCwalina,
Mohit-Chakraborty,
Yao725,
ahamad-MS,
allenjzhang,
annelo-msft,
archerzz,
benbp,
chidozieononiwu,
danieljurek,
fengzhou-msft,
jfggdl,
jsquire,
kinelski,
m-nash,
markcowl,
pakrym,
serkantkaraca,
tg-msft and
weshaggard
as code owners
|
This pull request is protected by Check Enforcer. |
yukun-dong
added a commit
that referenced
this pull request
Nov 19, 2021
This reverts commit c64ce6c.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
17 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All SDK Contribution checklist:
This checklist is used to make sure that common guidelines for a pull request are followed.
Draftmode if it is:General Guidelines and Best Practices
Testing Guidelines
SDK Generation Guidelines
*.csprojandAssemblyInfo.csfiles have been updated with the new version of the SDK. Please double check nuget.org current release version.Additional management plane SDK specific contribution checklist:
Note: Only applies to
Microsoft.Azure.Management.[RP]orAzure.ResourceManager.[RP]Management plane SDK Troubleshooting
If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add
new servicelabel and/or contact assigned reviewer.If the check fails at the
Verify Code Generationstep, please ensure:generate.ps1/cmdto generate this PR instead of callingautorestdirectly.Please pay attention to the @microsoft.csharp version output after running
generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.Note: We have recently updated the PSH module called by
generate.ps1to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:Old outstanding PR cleanup
Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.