TURN: Adding RouteType optional parameter to GetRelayConfiguration #25032

AriZavala2 · 2021-10-31T23:09:33Z

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
```
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
```

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

azure-sdk · 2021-10-31T23:17:49Z

API changes have been detected in Azure.Communication.NetworkTraversal. You can review API changes here

azure-sdk · 2021-11-10T02:35:13Z

API changes have been detected in Azure.Communication.NetworkTraversal. You can review API changes here

...ication.NetworkTraversal/tests/CommunicationRelayClient/CommunicationRelayClientLiveTests.cs

sdk/communication/Azure.Communication.NetworkTraversal/src/CommunicationRelayClient.cs

...ation/Azure.Communication.NetworkTraversal/tests/samples/Sample1_CommunicationRelayClient.cs

minnieliu · 2021-11-15T22:09:22Z

Can you also update the README.md and CHANGELOG.md with your changes?

azure-sdk · 2021-11-16T00:28:14Z

API changes have been detected in Azure.Communication.NetworkTraversal. You can review API changes here

DominikMe

Thanks for the changes! Some more comments, getting close :-)

sdk/communication/Azure.Communication.NetworkTraversal/CHANGELOG.md

...re.Communication.NetworkTraversal/api/Azure.Communication.NetworkTraversal.netstandard2.0.cs

sdk/communication/Azure.Communication.NetworkTraversal/src/CommunicationRelayClientOptions.cs

...ication.NetworkTraversal/tests/CommunicationRelayClient/CommunicationRelayClientLiveTests.cs

sdk/communication/Azure.Communication.NetworkTraversal/README.md

azure-sdk · 2021-11-17T01:01:14Z

API changes have been detected in Azure.Communication.NetworkTraversal. You can review API changes here

AriZavala2 · 2021-11-17T17:48:53Z

/azp run net - Azure.Communication.NetworkTraversal - tests

azure-pipelines · 2021-11-17T17:49:05Z

Azure Pipelines successfully started running 1 pipeline(s).

DominikMe

Thanks for making the changes! More comments but it's mainly requests to delete code :-)

...mmunication/Azure.Communication.NetworkTraversal/samples/Sample1_CommunicationRelayClient.md

sdk/communication/Azure.Communication.NetworkTraversal/src/CommunicationRelayClient.cs

...ommunication/Azure.Communication.NetworkTraversal/src/Models/GetRelayConfigurationOptions.cs

azure-sdk · 2021-11-18T00:51:08Z

API changes have been detected in Azure.Communication.NetworkTraversal. You can review API changes here

* [SignalR] Add Strongly typed serverless hub (#25075) # All SDK Contribution checklist: This checklist is used to make sure that common guidelines for a pull request are followed. - [x] **Please open PR in `Draft` mode if it is:** - Work in progress or not intended to be merged. - Encountering multiple pipeline failures and working on fixes. - [ ] If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. - [x] **I have read the [contribution guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md).** - [x] **The pull request does not introduce [breaking changes](https://github.com/dotnet/corefx/blob/master/Documentation/coding-guidelines/breaking-change-rules.md).** ### [General Guidelines and Best Practices](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#general-guidelines) - [x] Title of the pull request is clear and informative. - [x] There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, [see this page](https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/cleaning-up-commits.md). ### [Testing Guidelines](https://github.com/Azure/azure-sdk-for-net/blob/main/CONTRIBUTING.md#testing-guidelines) - [x] Pull request includes test coverage for the included changes. * Increment version for operationalinsights releases (#25345) Increment package version after release of Microsoft.Azure.OperationalInsights * [ACR] Update SDK to c8d9a26a of REST spec (#24341) * Generate changes before any transforms * Regenerate code after adding transforms * Update internal interface and cleanup removed properties * Update public API * Update service version and test session records * Fix params for `ExchangeAadAccessTokenForAcrRefreshToken()` Set `GrantType` as `AccessToken`. `tenant` and `refreshToken` are null. * Update public API * Update session records * Update Changelog * Sync eng/common directory with azure-sdk-tools for PR 2290 (#25372) * update docker-start-proxy to have a slightly different default parameter * we were surrounding the value in single quotes, breaking recording load Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> * [Event Hubs] Flaky Test Fix (#25346) The focus of these changes is to stabilize some tests with non-deterministic behavior that have recently shown to be flaky when run in CI pipelines. * [Azure.Core] Logging Sample Enhancement (#25389) # Summary The focus of these changes is to enhance the logging section of the diagnostics sample to include details about the lifetime of the `AzureEventSourceListener`. We received some customer feedback that it was unclear where they needed to create the listener and that it had to have the appropriate scope to be able to capture logs. * [LLC] Implement RequestOptions.AddPolicy (#25214) * add test for AddPolicy * share proposed refactoring to HttpPipelineExtensions * ideas in the direction of implementation * mark retry policy * revert mark retry policy * shifting API around * experiment with using MemoryPool * use ArrayPool * use ArrayPool * add tests * update API * throw if didn't use pipeline builder * pr feedback and merge follow-up * pr fb and merge follow-up * pr fb * simplify request pipeline creation * move AddPolicy tests to Core; pr fb * nit * pr fb * pr fb & fix build * pr fb * pr fb & build fix * pr fb * pr fb * pr fb & fix core ci * Update CODEOWNERS (#25393) * Microsoft.Azure.Management.Avs 3.0.0 (#25276) * use main branch * generated for 2021-12-01 API * switch AvsTests to test mock_api server * Updating recorded test files also tested with playback * generate from main * set to 3.0.0 * Updating test records for AVS/2021-12 * Updating new test records * Updated test records Co-authored-by: Pinak Kelkar <pinakkelkar@microsoft.com> * KeyVault Preview 2021 06 (#25282) * Generated new code from 06-preview version * Regenerated code to pick up additional changes. * Update unit tests for 2021-06-01-preview and SystemData * updated metadata * Updated package version to 4.0.0-preview.1 Co-authored-by: Soohwan Kim <sookim@microsoft.com> Co-authored-by: Jiacheng Liu <jiachengliu@microsoft.com> * Increment version for containerregistry releases (#25397) Increment package version after release of Azure.Containers.ContainerRegistry * Add storage mgmt test (#25395) * add tests from track1 * add and modify some tests add tests modify tests * ignore PITR test case * ignore PrivateEndpointConnection tests * Update changelog for AddPolicy (#25394) * [Event Hubs] Sample updates for the Buffered Producer (#25388) * [Event Hubs] Sample updates for the Buffered Producer The focus of these changes is to incorporate the `EventHubBufferedProducer` client into the Event Hubs samples for client types and publishing. Also included is a clarification for the logging sample, calling out the lifetime needs for the listener. * TURN: Adding RouteType optional parameter to GetRelayConfiguration (#25032) * Add Anycast parameter to GetRelayConfiguration * Update PR, removing unused snippet. * Modified swagger, so adding new autogenerated code * Update PR * Update PR, add new recordings, reenable non-identity tests * Adding GetRelayOptions and updating Readme and changelog * Update PR * Update PR * [MetricsAdvisor] Add tests for Skip and MaximumPageSize input options in AnomalyAlertConfigurationLiveTests and AnomalyDetectionConfigurationLiveTests (#24540) * Fix CanSetContentLengthOverMaxInt (#25404) * Update changelog removing unused sections (#25413) * [template-LLC] Rename LLC to Dataplane Code Gen (#25390) * Rename LLC to Dataplane Code Gen * [Event Hubs] Buffered Producer Tweaks and Test Fixes (#25415) The focus of these changes is to trim some unused logic for enqueuing events, add some missing mock setups to guard against a test race, and improve some minor test structure. * Fix Broken link in EventGrid ReadMe (#25417) * [MetricsAdvisor] Moving to new MA resource (#25406) * Add Bryce into CodeOwners for IoT SDK team (#25420) * fix test error; update snippets Co-authored-by: yzt <zityang@microsoft.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Mohit Chakraborty <8271806+Mohit-Chakraborty@users.noreply.github.com> Co-authored-by: scbedd <45376673+scbedd@users.noreply.github.com> Co-authored-by: Jesse Squire <jsquire@microsoft.com> Co-authored-by: Anne Thompson <annelo@microsoft.com> Co-authored-by: Kamil Sobol <61715331+kasobol-msft@users.noreply.github.com> Co-authored-by: Cameron Taggart <cameron.taggart@microsoft.com> Co-authored-by: Pinak Kelkar <pinakkelkar@microsoft.com> Co-authored-by: kim-soohwan <40476315+kim-soohwan@users.noreply.github.com> Co-authored-by: Soohwan Kim <sookim@microsoft.com> Co-authored-by: Jiacheng Liu <jiachengliu@microsoft.com> Co-authored-by: AriZavala2 <77034370+AriZavala2@users.noreply.github.com> Co-authored-by: Gyeonghun Park <gp112795@gmail.com> Co-authored-by: Pavel Krymets <pavel@krymets.com> Co-authored-by: ShivangiReja <45216704+ShivangiReja@users.noreply.github.com> Co-authored-by: Chidozie Ononiwu (His Righteousness) <31145988+chidozieononiwu@users.noreply.github.com> Co-authored-by: Caio Saldanha <camaiaor@microsoft.com> Co-authored-by: brycewang-microsoft <94650966+brycewang-microsoft@users.noreply.github.com>

ghost added the Communication label Oct 31, 2021

AriZavala2 changed the title ~~Add Anycast parameter to GetRelayConfiguration~~ TURN: Adding RouteType optional parameter to GetRelayConfiguration Nov 1, 2021

AriZavala2 added 2 commits November 8, 2021 17:44

Add Anycast parameter to GetRelayConfiguration

ea9452f

Update PR, removing unused snippet.

be966b6

AriZavala2 force-pushed the AriZavala2/anycast_turn branch from d8030da to be966b6 Compare November 9, 2021 01:53

Modified swagger, so adding new autogenerated code

3c0cad4

AriZavala2 force-pushed the AriZavala2/anycast_turn branch 4 times, most recently from 23e7225 to 6c2700c Compare November 11, 2021 19:28

AriZavala2 requested review from KrzysztofCwalina and tg-msft as code owners November 11, 2021 19:28

Update PR

c8937a2

AriZavala2 force-pushed the AriZavala2/anycast_turn branch from 6c2700c to c8937a2 Compare November 11, 2021 20:52

DominikMe reviewed Nov 12, 2021

View reviewed changes

minnieliu reviewed Nov 15, 2021

View reviewed changes

...ation/Azure.Communication.NetworkTraversal/tests/samples/Sample1_CommunicationRelayClient.cs Show resolved Hide resolved

Update PR, add new recordings, reenable non-identity tests

0983345

AriZavala2 force-pushed the AriZavala2/anycast_turn branch from 3e0ac31 to 0983345 Compare November 16, 2021 04:49

DominikMe reviewed Nov 16, 2021

View reviewed changes

Adding GetRelayOptions and updating Readme and changelog

e20ca57

AriZavala2 force-pushed the AriZavala2/anycast_turn branch from 7b3b37e to e20ca57 Compare November 17, 2021 02:30

DominikMe reviewed Nov 17, 2021

View reviewed changes

Update PR

b04bd78

AriZavala2 force-pushed the AriZavala2/anycast_turn branch from 19b9d6e to b04bd78 Compare November 18, 2021 00:38

Update PR

d54d6e5

DominikMe approved these changes Nov 18, 2021

View reviewed changes

DominikMe merged commit 941cf29 into Azure:main Nov 18, 2021

commit-lint bot mentioned this pull request Dec 14, 2021

[pull] main from Azure:main Blaquez-home/azure-sdk-for-net#2

Open

TURN: Adding RouteType optional parameter to GetRelayConfiguration #25032

TURN: Adding RouteType optional parameter to GetRelayConfiguration #25032

Uh oh!

Conversation

AriZavala2 commented Oct 31, 2021

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

SDK Generation Guidelines

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

Uh oh!

azure-sdk commented Oct 31, 2021

Uh oh!

azure-sdk commented Nov 10, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

minnieliu commented Nov 15, 2021

Uh oh!

azure-sdk commented Nov 16, 2021

Uh oh!

DominikMe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-sdk commented Nov 17, 2021

Uh oh!

AriZavala2 commented Nov 17, 2021

Uh oh!

azure-pipelines bot commented Nov 17, 2021

Uh oh!

DominikMe left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azure-sdk commented Nov 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants