Resolve a few flaky Key Vault tests #19612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
heaths
commented
Mar 18, 2021
heaths
commented
- Wait longer for deleted keys. Resolves a recent issue found during live tests.
- Fix net5.0 tests on OSX.
- Add EventSource for CertificateOperation. Adds more logging to better diagnose how Flaky tests for CancelCertificateOperation #17718 is happening.
ghost
added
the
christothes
reviewed
Mar 18, 2021
sdk/keyvault/Azure.Security.KeyVault.Certificates/src/CertificateOperation.cs
Outdated
Show resolved
Hide resolved
pakrym
approved these changes
Mar 18, 2021
Added more logging to better diagnose how Azure#17718 is happening.
...in case the event source is initially disabled, but enabled in the middle (elapsed time would be very long).
christothes
approved these changes
Mar 23, 2021
Mohit-Chakraborty
pushed a commit
to Mohit-Chakraborty/azure-sdk-for-net
that referenced
this pull request
Mar 23, 2021
* Wait longer for deleted keys * Fix net5.0 tests on OSX * Add EventSource for CertificateOperation Added more logging to better diagnose how Azure#17718 is happening. * Always get start time from stopwatch ...in case the event source is initially disabled, but enabled in the middle (elapsed time would be very long). * Fix broken test on OSX * More fixes for OSX * Resolve PR feedback * Re-enable some tests and increasing polling interval * Ignore VerifyECDecoderPrime256v1Imported on OSX
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.