Skip to content

Commit

Permalink
Re-enable some tests and increasing polling interval
Browse files Browse the repository at this point in the history
  • Loading branch information
heaths committed Mar 22, 2021
1 parent c58339c commit bd4b247
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 6 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -228,8 +228,8 @@ public async Task VerifyCertificateOperationError()

RegisterForCleanup(certName);

using CancellationTokenSource cts = new CancellationTokenSource(TimeSpan.FromMinutes(1));
TimeSpan pollingInterval = TimeSpan.FromSeconds((Mode == RecordedTestMode.Playback) ? 0 : 1);
using CancellationTokenSource cts = new CancellationTokenSource(TimeSpan.FromMinutes(2));
TimeSpan pollingInterval = TimeSpan.FromSeconds((Mode == RecordedTestMode.Playback) ? 0 : 2);

while (!operation.HasCompleted)
{
Expand Down Expand Up @@ -321,8 +321,8 @@ public async Task VerifyGetCertificateCompletedSubsequently()
CertificateOperation operation = new CertificateOperation(Client, certName);

// Need to call the real async wait method or the sync version of this test fails because it's using the instrumented Client directly.
using CancellationTokenSource cts = new CancellationTokenSource(TimeSpan.FromMinutes(1));
TimeSpan pollingInterval = TimeSpan.FromSeconds((Mode == RecordedTestMode.Playback) ? 0 : 1);
using CancellationTokenSource cts = new CancellationTokenSource(TimeSpan.FromMinutes(2));
TimeSpan pollingInterval = TimeSpan.FromSeconds((Mode == RecordedTestMode.Playback) ? 0 : 2);

await operation.WaitForCompletionAsync(pollingInterval, cts.Token);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ namespace Azure.Security.KeyVault.Certificates.Tests
public class LightweightPkcs8DecoderTests
{
[Test]
[Ignore("Temporarily disable until https://github.com/Azure/azure-sdk-for-net/pull/19612")]
public void VerifyECDecoderPrime256v1Imported() =>
VerifyECDecoder(EcPrime256v1PrivateKeyImported, CertificateKeyCurveName.P256, @"DFTTJrKrtao7G/B0bK5yv+mX0/3Sefv2MS1gzd6DfYH2ASe9Tw7rSbLjZ8wM0p7I/opbIG1+zHhpYqOGnQNQyw==", EcPrime256v1CertificateImported);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,6 @@ public void LoadRSACertificate()
}

[Test]
[Ignore("Temporarily disable until https://github.com/Azure/azure-sdk-for-net/pull/19612")]
public void LoadECDsaPrime256v1Certificate()
{
#if NET461
Expand Down

0 comments on commit bd4b247

Please sign in to comment.