Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test coverage for MHSM and local cryptography #18902

Merged
merged 3 commits into from
Feb 22, 2021
Merged

Add test coverage for MHSM and local cryptography #18902

merged 3 commits into from
Feb 22, 2021

Conversation

heaths
Copy link
Member

@heaths heaths commented Feb 20, 2021

Resolves #16713
Resolves #18864

Temporarily works around #18800 by trimming leading zeros coming back from the service after updating a key and before asserting equality.

@heaths
Add test coverage for MHSM and local cryptography
6e2c699 
Resolves Azure#16713
Resolves Azure#18864

Temporarily works around Azure#18800 by trimming leading zeros coming back from the service after updating a key and before asserting equality.
@heaths heaths requested a review from schaabs as a code owner February 20, 2021 23:59
@ghost ghost added the KeyVault label Feb 20, 2021
@heaths
Copy link
Member Author

heaths commented Feb 21, 2021

@schaabs @christothes @pakrym the PR is not actually that big - only 10 files, and mostly small changes - if you look at the non-recordings: https://github.com/Azure/azure-sdk-for-net/pull/18902/files?file-filters%5B%5D=.cs&file-filters%5B%5D=.csproj

heaths
heaths commented Feb 21, 2021
View reviewed changes
sdk/keyvault/Azure.Security.KeyVault.Keys/src/JsonWebKey.cs
{
s_rsaFactory = p =>
{
RSA rsa = RSA.Create();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On Framework, this won't create the CNG version of RSA, which later won't support RSA-OAEP-SHA256.

@heaths heaths merged commit dfbb155 into Azure:master Feb 22, 2021
@heaths heaths deleted the issue16713 branch February 22, 2021 21:11
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request May 24, 2022
@abhahn @bidisha-c
@ChongTang @moabba @nourhaanfarid
CodeGen from PR 19186 in Azure/azure-rest-api-specs
cbcd4c6 
Merge Cognitive Services - Language pillar version 2022-05-15-preview to main (Azure#19186)

* Updated May-1 preview to include changes from March-1 preview (Azure#18580)

* Updated May-1 preview to include changes from March-1 preview

* Fixed a missed api version update in an example file

Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com>

* [Language API 2022-05-01-Preview]Conversation API Async - Conversational Summarization and Conversational PII (Azure#17847)

* Adds base for updating Language from version preview/2022-02-01-preview to version 2022-04-01-preview

* Updates readme

* Updates API version in new specs and examples

* [Language API 2022-04-01-Preview] Feature conversation PII redaction and issue resolution summarization

* Add Issue Resolution Summary

* Address comments

* address pretty chek and spell check issues

* address file name mismatch issue

* typo

* Add IRD updates

* Add IRD Schema changes

* Response Files content update

* Address feedback

* Address PR comments

* Address comments

* Add the May API version

* Address comments

* Remove 04-01 and address comments

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/textanalytics.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Address feedback V-1.

* Address all comments expect model + enum descriptions

* Fx validations

* Missed files

* Conversation Item modality issue

* Update PII Task

* Address Spec validation errors

* Updates

* Fix PII issues

* Add readonly

* Update schema

* Updates

* Bring back Text Conversation Item

* Update example

* Space in Json

* Address comments

* Address one more comments

* Fix model validation

* Fix

* Update spec

* Address comments

* Move requestStatistics, prebuiltResult, error and warnings object to common

* Address circular dependency

Co-authored-by: Abigail Hartman <Abigail.Hahn@microsoft.com>
Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Rename version from 2022-05-01-preview to 2022-05-15-preview (Azure#18737)

* Update CLU swagger (Azure#18739)

Co-authored-by: Chong Tang <chot@microsoft.com>

* Use azure-sdk-for-net-track2 for validation (Azure#18755)

* Bidishac/update field description (#18787)

* Update the messaging on the parameter type

* Update the documentation of the redactionSource field

* Update specification/cognitiveservices/data-plane/Language/preview/2022-05-15-preview/analyzeconversations.json

Co-authored-by: Heath Stewart <heaths@microsoft.com>

Co-authored-by: Chong Tang <ct4ew@virginia.edu>
Co-authored-by: Heath Stewart <heaths@microsoft.com>

* Unify the runtime and authoring APIs (Azure#18837)

* unifying single classification and multi classification to return array of class (Azure#18902)

* Renaming in 2022-05-15-preview (Azure#18929)

Co-authored-by: Chong Tang <chot@microsoft.com>

* Rename 'summary' in summaryAspects to 'issue' (Azure#18941)

* Rename 'summary' in summaryAspects to 'issue'

* Merge issues

* Update model version value

* Merge 2022-05-01-GA authoring updates and "LUIS" string case update into 2022-05-15-preview branch (Azure#18943)

* Merge 2022-05-01-GA files changes into 2022-05-15-preview branch

* Address Avocado issues and revert case update for Luis

* Add the missing error codes

* Fix avocado

* Avocado fix

* Add api-version parameter to cancel job endpoint (Azure#18986)

* Add api-version parameter to cancel job endpoint

* Fix taskState and jobState

* Revert "Fix taskState and jobState"

This reverts commit 148dd2183249add89a090721db36a14c2b15d9bd.

* Update LUIS to Luis in model names (Azure#19012)

* Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (Azure#19031)

Co-authored-by: Chong Tang <chot@microsoft.com>

* Added fhir feature updates to 2022-05-15-preview (Azure#19092)

Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com>

* Add cancel endpoint for conversations (Azure#19025)

* Add cancel endpoint for conversations

* Update examples path

* Make the input for transcriptConversationItem optional

* Bidishac/update enum name (Azure#19149)

* Update name to CreditCard

* Update entity categories for PII for build

* Keep SSN

* Revert "Keep SSN"

This reverts commit 77a92119ebd71cf5d5c7f201d402514756289ec2.

* Update readme.md

Co-authored-by: Abigail Hartman <Abigail.Hahn@microsoft.com>
Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com>
Co-authored-by: Bidisha Chakraborty <29803402+bidisha-c@users.noreply.github.com>
Co-authored-by: Chong Tang <ct4ew@virginia.edu>
Co-authored-by: Chong Tang <chot@microsoft.com>
Co-authored-by: Mohamed Abbas <moaba@microsoft.com>
Co-authored-by: Nourhan <92883092+nourhaanfarid@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christothes christothes christothes left review comments

@pakrym pakrym pakrym approved these changes

@schaabs schaabs Awaiting requested review from schaabs

Assignees
No one assigned
Labels
KeyVault
Projects
None yet
Milestone
No milestone
3 participants
@heaths @christothes @pakrym