Adding support for MySQL and PG migrations #17847
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
temandr
requested review from
allenjzhang,
bquantump,
m-nash,
markcowl,
nisha-bhatia and
YalinLi0312
as code owners
|
@m-nash This is ready to be checked in and released. |
temandr
force-pushed
the
release/dmssdkforpg
branch
from
a40443e
to
fc3927e
Compare
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
|
/azp run net - mgmt - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
m-nash
requested changes
Feb 2, 2021
| @@ -66,8 +66,8 @@ public MongoDbCollectionProgress() | |||
| /// object. For a collection, this is the database-qualified name. For | |||
| /// a database, this is the database name. For the overall migration, | |||
| /// this is null.</param> | |||
| public MongoDbCollectionProgress(long bytesCopied, long documentsCopied, string elapsedTime, IDictionary<string, MongoDbError> errors, long eventsPending, long eventsReplayed, string resultType, string state, long totalBytes, long totalDocuments, System.DateTimeOffset? lastEventTime = default(System.DateTimeOffset?), System.DateTimeOffset? lastReplayTime = default(System.DateTimeOffset?), string name = default(string), string qualifiedName = default(string)) | |||
| : base(bytesCopied, documentsCopied, elapsedTime, errors, eventsPending, eventsReplayed, resultType, state, totalBytes, totalDocuments, lastEventTime, lastReplayTime, name, qualifiedName) | |||
| public MongoDbCollectionProgress(long bytesCopied, long documentsCopied, string elapsedTime, IDictionary<string, MongoDbError> errors, long eventsPending, long eventsReplayed, string state, long totalBytes, long totalDocuments, System.DateTimeOffset? lastEventTime = default(System.DateTimeOffset?), System.DateTimeOffset? lastReplayTime = default(System.DateTimeOffset?), string name = default(string), string qualifiedName = default(string)) | |||
There was a problem hiding this comment.
This results in a breaking change since we are removing a parameter from a public method.
The spec PR does not have the Approved-BreakingChanges label please work with the breaking change board to get this label added.
25 tasks
|
I approve this breaking change. |
m-nash
approved these changes
Feb 19, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-net
that referenced
this pull request
May 24, 2022
Merge Cognitive Services - Language pillar version 2022-05-15-preview to main (Azure#19186) * Updated May-1 preview to include changes from March-1 preview (Azure#18580) * Updated May-1 preview to include changes from March-1 preview * Fixed a missed api version update in an example file Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com> * [Language API 2022-05-01-Preview]Conversation API Async - Conversational Summarization and Conversational PII (Azure#17847) * Adds base for updating Language from version preview/2022-02-01-preview to version 2022-04-01-preview * Updates readme * Updates API version in new specs and examples * [Language API 2022-04-01-Preview] Feature conversation PII redaction and issue resolution summarization * Add Issue Resolution Summary * Address comments * address pretty chek and spell check issues * address file name mismatch issue * typo * Add IRD updates * Add IRD Schema changes * Response Files content update * Address feedback * Address PR comments * Address comments * Add the May API version * Address comments * Remove 04-01 and address comments * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json Co-authored-by: Heath Stewart <heaths@microsoft.com> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/common.json Co-authored-by: Heath Stewart <heaths@microsoft.com> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json Co-authored-by: Heath Stewart <heaths@microsoft.com> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/analyzeconversations.json Co-authored-by: Heath Stewart <heaths@microsoft.com> * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-01-preview/textanalytics.json Co-authored-by: Heath Stewart <heaths@microsoft.com> * Address feedback V-1. * Address all comments expect model + enum descriptions * Fx validations * Missed files * Conversation Item modality issue * Update PII Task * Address Spec validation errors * Updates * Fix PII issues * Add readonly * Update schema * Updates * Bring back Text Conversation Item * Update example * Space in Json * Address comments * Address one more comments * Fix model validation * Fix * Update spec * Address comments * Move requestStatistics, prebuiltResult, error and warnings object to common * Address circular dependency Co-authored-by: Abigail Hartman <Abigail.Hahn@microsoft.com> Co-authored-by: Heath Stewart <heaths@microsoft.com> * Rename version from 2022-05-01-preview to 2022-05-15-preview (Azure#18737) * Update CLU swagger (Azure#18739) Co-authored-by: Chong Tang <chot@microsoft.com> * Use azure-sdk-for-net-track2 for validation (Azure#18755) * Bidishac/update field description (#18787) * Update the messaging on the parameter type * Update the documentation of the redactionSource field * Update specification/cognitiveservices/data-plane/Language/preview/2022-05-15-preview/analyzeconversations.json Co-authored-by: Heath Stewart <heaths@microsoft.com> Co-authored-by: Chong Tang <ct4ew@virginia.edu> Co-authored-by: Heath Stewart <heaths@microsoft.com> * Unify the runtime and authoring APIs (Azure#18837) * unifying single classification and multi classification to return array of class (Azure#18902) * Renaming in 2022-05-15-preview (Azure#18929) Co-authored-by: Chong Tang <chot@microsoft.com> * Rename 'summary' in summaryAspects to 'issue' (Azure#18941) * Rename 'summary' in summaryAspects to 'issue' * Merge issues * Update model version value * Merge 2022-05-01-GA authoring updates and "LUIS" string case update into 2022-05-15-preview branch (Azure#18943) * Merge 2022-05-01-GA files changes into 2022-05-15-preview branch * Address Avocado issues and revert case update for Luis * Add the missing error codes * Fix avocado * Avocado fix * Add api-version parameter to cancel job endpoint (Azure#18986) * Add api-version parameter to cancel job endpoint * Fix taskState and jobState * Revert "Fix taskState and jobState" This reverts commit 148dd2183249add89a090721db36a14c2b15d9bd. * Update LUIS to Luis in model names (Azure#19012) * Copy QuestionAnswering definitions to common.json and refer them in analyzeconversations.json (Azure#19031) Co-authored-by: Chong Tang <chot@microsoft.com> * Added fhir feature updates to 2022-05-15-preview (Azure#19092) Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com> * Add cancel endpoint for conversations (Azure#19025) * Add cancel endpoint for conversations * Update examples path * Make the input for transcriptConversationItem optional * Bidishac/update enum name (Azure#19149) * Update name to CreditCard * Update entity categories for PII for build * Keep SSN * Revert "Keep SSN" This reverts commit 77a92119ebd71cf5d5c7f201d402514756289ec2. * Update readme.md Co-authored-by: Abigail Hartman <Abigail.Hahn@microsoft.com> Co-authored-by: Abigail Hartman <Abigail.Hartman@microsoft.com> Co-authored-by: Bidisha Chakraborty <29803402+bidisha-c@users.noreply.github.com> Co-authored-by: Chong Tang <ct4ew@virginia.edu> Co-authored-by: Chong Tang <chot@microsoft.com> Co-authored-by: Mohamed Abbas <moaba@microsoft.com> Co-authored-by: Nourhan <92883092+nourhaanfarid@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related swagger change: Azure/azure-rest-api-specs#10494
Adding support for MySQL and PG migrations into the SDK.