Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove swaggers and add generate.ps1 #12992

Merged

Conversation

christothes
Copy link
Member

fixes #12990

@christothes christothes added KeyVault Client This issue points to a problem in the data-plane of the library. labels Jun 24, 2020
@christothes christothes requested a review from heaths June 24, 2020 22:10
@christothes christothes self-assigned this Jun 24, 2020
@@ -0,0 +1,33 @@
#
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autorest.md supports multiple links, I'm told. Please try it so we don't have custom code to maintain. Use full commit-based URLs so that taking new ones is explicitly opt-in.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're correct! Last time I tried, it failed.

Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@christothes christothes merged commit f9033cc into Azure:master Jun 24, 2020
prmathur-microsoft pushed a commit that referenced this pull request Jul 8, 2020
* Remove swaggers and add generate.ps1

* update autorest instructions

* fix swaggers to be links (it works now!)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key Vault swaggers should not be checked in
2 participants