[Recorder] Followup of #7083 - Coupling RecorderEnvironmentSetup with the record call
#7085
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are we adding CHANGELOG entries to the recorder? I wonder if we should start. Other than that, once this PR works, I think we'll be good to go. This is probably the happiest path at the moment. Also, any thoughts on unit tests for this? |
Good suggestion. I was thinking too. Still, a changelog with just the dates would be good for keeping track things. |
HarshaNalluru
requested review from
jeremymeng,
jiacfan,
ljian3377,
sadasant,
vinjiang and
XiaoningLiu
as code owners
HarshaNalluru
added
Client
…6-soft-record-prereq
…followup/7083-storage-queue
This was referenced Jan 28, 2020
…followup/7083-storage-queue
sadasant
reviewed
Jan 28, 2020
| ], | ||
| queryParametersToSkip: [] | ||
| }; | ||
| const recorder = record(that, recorderEnvSetup); |
|
Tested the playback locally for all the storage and keyvault packages at 0fb53c7. |
…6-soft-record-prereq
…followup/7083-storage-queue
62 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are as per the discussions with @xirzec and @sadasant .
Changes in the PR
setReplaceableVariables,setReplacements,skipQueryParamsmethods of the recorder are no longer exposed.RecorderEnvironmentSetuptype is being introduced. An object of this type is expected to be passed in therecord()call.record(this)->record(this, recorderEnvSetup).RecorderEnvironmentSetupwith the record call #7083 to make the build succeedRecorderEnvironmentSetupwith the record call #7083 has the changes corresponding to the recorder package only).