[Recorder] Coupling RecorderEnvironmentSetup with the record call
#7083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HarshaNalluru
force-pushed
the
harshan/issue/5156-soft-record-prereq
branch
from
b297cff
to
e72d9de
Compare
HarshaNalluru
added
Client
|
Should we merge #7085 directly, since these changes aren't compatible with the existing tests? |
…6-soft-record-prereq
HarshaNalluru
added a commit
that referenced
this pull request
Jan 28, 2020
…th the record call (#7085) * add brand new RecorderEnvironmentSetup * import RecorderEnvironmentSetup from the utils and pass on to setEnvironmentOnLoad * update exports in the recorder * import RecorderEnvironmentSetup in storage-queue * update tests with recorderEnvSetup accordingly * cleanup - remove dependency on env variables in replaceableVariables * Update testutils.common.ts files for all storage packages * file-share tests fixed * blob tests fix * blob fix leftovers * recordings for the beforeEach update * storage-file-datalake update recorderEnvSetup * fix formatting * DataLakeService FIX * FILE DATALAKE - left overs * updated Guidelines accordingly * update keyvault tests * Update Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in this PR are as per the discussions with @xirzec and @sadasant .
Description
RecorderEnvironmentSetupwith the record call #7085Required for #5156