Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eventhub] - Move tracing spec to internal #21258

Merged
merged 3 commits into from
Apr 6, 2022

Conversation

maorleger
Copy link
Member

Packages impacted by this PR

event-hubs

Issues associated with this PR

Fixes #21226

Describe the problem that is addressed by this PR

The tracing client test adds an internal reference; however, the test is still
not excluded during min/max due to the nesting of the tracing reference. That
will be fixed separately, but it also makes sense to make this an internal test
as it tests the internals of how we trace.

What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?

Are there test cases added in this PR? (If not, why?)

N/A

Provide a list of related PRs (if any)

Command used to generate this PR: (Applicable only to SDK release request PRs)

Checklists

  • Added impacted package name to the issue description.
  • Does this PR need any fixes in the SDK Generator?** (If so, create an Issue in the Autorest/typescript repository and link it here.)
  • Added a changelog (if necessary).

@azure-sdk
Copy link
Collaborator

API change check for @azure/event-hubs

API changes are not detected in this pull request for @azure/event-hubs

Copy link
Member

@deyaaeldeen deyaaeldeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't claim I understand the internals of the test but looks good to me at a high level! One thing for me to look at is whether it is really nodejs-only.

@maorleger maorleger merged commit 6256e86 into Azure:main Apr 6, 2022
@maorleger maorleger deleted the move-tracing-spec-to-internal branch April 6, 2022 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants