Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Event Hubs] Create clients using Azure Identity tracing getEventHubProperties() creates a span with a peer.address attribute as the FQNS failing in nightly runs #21226

Closed
v-jiaodi opened this issue Apr 6, 2022 · 1 comment · Fixed by #21258
Closed

[Event Hubs] Create clients using Azure Identity tracing getEventHubProperties() creates a span with a peer.address attribute as the FQNS failing in nightly runs #21226

v-jiaodi opened this issue Apr 6, 2022 · 1 comment · Fixed by #21258
Assignees
@maorleger
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs needs-team-triage Workflow: This issue needs the team to triage. test-reliability Issue that causes tests to be unreliable

Comments

@v-jiaodi
Copy link
Member

v-jiaodi commented Apr 6, 2022

Event Hubs nightly test runs are failing with:

Error message:
expected false to be true

Stack trace:
AssertionError: expected false to be true
at Context. (/mnt/vss/_work/1/s/sdk/eventhub/event-hubs/test/public/node/client.spec.ts:121:16)
at runMicrotasks ()
at processTicksAndRejections (internal/process/task_queues.js:97:5)

For more details check here:
@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 6, 2022
@azure-sdk azure-sdk added Client This issue points to a problem in the data-plane of the library. Event Hubs needs-team-triage Workflow: This issue needs the team to triage. labels Apr 6, 2022
@ghost ghost removed the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Apr 6, 2022
@v-xuto v-xuto added the test-reliability Issue that causes tests to be unreliable label Apr 6, 2022
@maorleger
Copy link
Member

I'll take this @jeremymeng since it's tracing related

@maorleger maorleger assigned maorleger and unassigned jeremymeng Apr 6, 2022
@maorleger maorleger mentioned this issue Apr 6, 2022
Merged
3 tasks
maorleger added a commit that referenced this issue Apr 6, 2022
@maorleger
[eventhub] - Move tracing spec to internal (#21258)
6256e86 
### Packages impacted by this PR
event-hubs

### Issues associated with this PR
Fixes #21226

### Describe the problem that is addressed by this PR
The tracing client test adds an internal reference; however, the test is still
not excluded during min/max due to the nesting of the tracing reference. That
will be fixed separately, but it also makes sense to make this an internal test
as it tests the internals of how we trace.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@maorleger maorleger

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs needs-team-triage Workflow: This issue needs the team to triage. test-reliability Issue that causes tests to be unreliable
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[eventhub] - Move tracing spec to internal maorleger/azure-sdk-for-js
5 participants
@maorleger @jeremymeng @azure-sdk @v-xuto @v-jiaodi