Exclude browser tests #20342
Merged
Exclude browser tests #20342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run js - data-tables - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jeremymeng
approved these changes
Feb 11, 2022
Filed #20346 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
@azure/data-tables
Describe the problem that is addressed by this PR
Live tests are failing when running node in Windows. Dev-tool's browser filter doesn't seem to be picked up correctly by windows.
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
To mitigate the failure I'm adding an explicit exclude for browser tests in the integration-test:node command. On the side I'm investigating why the original filter in dev-tool doesn't work as expected