Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevTool] Run test:node command doesn't ignore browser folder in Windows #20346

Closed
joheredi opened this issue Feb 11, 2022 · 2 comments
Closed
Labels
dev-tool Issues related to the Azure SDK for JS dev-tool test-utils-recorder Label for the issues related to the common recorder

Comments

@joheredi
Copy link
Member

joheredi commented Feb 11, 2022

Running the dev-tool comman dev-tool run test:node-js-input -- --timeout 5000000 'dist-esm/test/**/*.spec.js' doesn't seem to effectively ignore the browser folder when run in Windows systems, Mac and Linux seem to ignore correctly.

For example the data-tables SDK has the following folder structure:

tables/
   data-tables/
      test/
         internal/
            node/
            browser/
            *.spec.ts
         public/
            *.spec.ts

The filter path that dev-tool has is not excluding browser in Windows systems

: '--timeout 5000000 "dist-esm/test/{,!(browser)/**/}/*.spec.js"';

@joheredi joheredi added test-utils-recorder Label for the issues related to the common recorder dev-tool Issues related to the Azure SDK for JS dev-tool labels Feb 11, 2022
@JonathanCrd
Copy link
Member

Something that could be related to this:
running "unit-test:node": "dev-tool run test:node-ts-input -- --timeout 1200000 --exclude 'test/**/browser/*.spec.ts' 'test/**/*.spec.ts'" is not recursive for Ubuntu and MacOS. Windows seems to be fining all tests inside any directory inside test/.

An example can be found in this PR: #20178 (comment)

@HarshaNalluru HarshaNalluru added this to the [2022] May milestone Apr 12, 2022
@JonathanCrd JonathanCrd modified the milestones: [2022] May, Backlog Apr 28, 2022
@JonathanCrd JonathanCrd removed their assignment May 18, 2022
Copy link

Hi @joheredi, we deeply appreciate your input into this project. Regrettably, this issue has remained inactive for over 2 years, leading us to the decision to close it. We've implemented this policy to maintain the relevance of our issue queue and facilitate easier navigation for new contributors. If you still believe this topic requires attention, please feel free to create a new issue, referencing this one. Thank you for your understanding and ongoing support.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Mar 13, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2024
@xirzec xirzec removed this from the Backlog milestone May 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dev-tool Issues related to the Azure SDK for JS dev-tool test-utils-recorder Label for the issues related to the common recorder
Projects
None yet
Development

No branches or pull requests

4 participants