-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the word experimental in readmes #18773
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should our customers expect something in particular when they see the experimental word in the docs? does it affect versioning expectation? since I never heard about it before I guess it is meaningless and should be removed but I could be wrong.
The presence of alpha/beta in the package version should reflect the supportability aspect of things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with the change. I think alpha/beta versions should indicate the experimental nature of libraries. While the ones we already GAd are definitely no longer experimental
That seems to be a good use. In this case, perhaps leave it in core-crypto? EDIT: and core-util. Also to be less confusing, should we say unpublished instead? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, though as Deya mentions, perhaps revert for the packages that haven't GA'd?
4856914
to
da3e1c4
Compare
Fair point. Left the term experimental in core-crypto and core-util |
Hello @ramya-rao-a! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
We have the word "Experimental" in the titles in the readme files for our core packages. My guess is that we started with this when we were working on core v2, forgot to remove it when core v2 went GA and all our newer core packages from them did a copy/paste :) @xirzec, @joheredi Am I missing something?
* Check is value is undefined in appendQueryParams (#18621) * Check is value is undefined in appendQueryParams * Minor change * Response to PR comments * Update sdk/core/core-client/src/urlHelpers.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Minor refactor Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Post release automated changes for core releases (#18358) Post release automated changes for azure-core-client * Remove the word experimental in readmes (#18773) We have the word "Experimental" in the titles in the readme files for our core packages. My guess is that we started with this when we were working on core v2, forgot to remove it when core v2 went GA and all our newer core packages from them did a copy/paste :) @xirzec, @joheredi Am I missing something? * Update Changelog to include query param check (#18851) * Update Changelog to include query param check * Update sdk/core/core-client/CHANGELOG.md Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * fix reinstall native dependency (#18582) * Generate absolute path for symlink to reinstall native dependency Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
…) (#18925) * Check is value is undefined in appendQueryParams (#18621) * Check is value is undefined in appendQueryParams * Minor change * Response to PR comments * Update sdk/core/core-client/src/urlHelpers.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Minor refactor Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Post release automated changes for core releases (#18358) Post release automated changes for azure-core-client * Remove the word experimental in readmes (#18773) We have the word "Experimental" in the titles in the readme files for our core packages. My guess is that we started with this when we were working on core v2, forgot to remove it when core v2 went GA and all our newer core packages from them did a copy/paste :) @xirzec, @joheredi Am I missing something? * Update Changelog to include query param check (#18851) * Update Changelog to include query param check * Update sdk/core/core-client/CHANGELOG.md Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * fix reinstall native dependency (#18582) * Generate absolute path for symlink to reinstall native dependency Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
Update compute.json (Azure#18773)
We have the word "Experimental" in the titles in the readme files for our core packages.
My guess is that we started with this when we were working on core v2, forgot to remove it when core v2 went GA and all our newer core packages from them did a copy/paste :)
@xirzec, @joheredi Am I missing something?