fix reinstall native dependency #18582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
force-pushed
the
keytar_debug
branch
from
17e423e
to
c67c05f
Compare
praveenkuttappan
requested review from
danieljurek,
mikeharder and
weshaggard
as code owners
weshaggard
reviewed
Nov 9, 2021
mikeharder
requested changes
Nov 9, 2021
mikeharder
requested changes
Nov 9, 2021
mikeharder
requested changes
Nov 9, 2021
praveenkuttappan
commented
Nov 9, 2021
| @@ -42,7 +44,6 @@ steps: | |||
| # pnpm v6 replaces '/' in package names with '+' to reduce nesting directory in virtual store so we need to | |||
| # change it back | |||
| $packageAtVersion = $packageAtVersion.Replace("+", "/") | |||
|
|
|||
There was a problem hiding this comment.
I have reverted this new line change and it's showing up correctly on view file of latest commit.
mikeharder
approved these changes
Nov 9, 2021
danieljurek
pushed a commit
that referenced
this pull request
Nov 10, 2021
* Generate absolute path for symlink to reinstall native dependency
deyaaeldeen
pushed a commit
to deyaaeldeen/azure-sdk-for-js
that referenced
this pull request
Nov 29, 2021
* Generate absolute path for symlink to reinstall native dependency
deyaaeldeen
added a commit
that referenced
this pull request
Dec 2, 2021
* Check is value is undefined in appendQueryParams (#18621) * Check is value is undefined in appendQueryParams * Minor change * Response to PR comments * Update sdk/core/core-client/src/urlHelpers.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Minor refactor Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Post release automated changes for core releases (#18358) Post release automated changes for azure-core-client * Remove the word experimental in readmes (#18773) We have the word "Experimental" in the titles in the readme files for our core packages. My guess is that we started with this when we were working on core v2, forgot to remove it when core v2 went GA and all our newer core packages from them did a copy/paste :) @xirzec, @joheredi Am I missing something? * Update Changelog to include query param check (#18851) * Update Changelog to include query param check * Update sdk/core/core-client/CHANGELOG.md Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * fix reinstall native dependency (#18582) * Generate absolute path for symlink to reinstall native dependency Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
deyaaeldeen
added a commit
that referenced
this pull request
Dec 2, 2021
…) (#18925) * Check is value is undefined in appendQueryParams (#18621) * Check is value is undefined in appendQueryParams * Minor change * Response to PR comments * Update sdk/core/core-client/src/urlHelpers.ts Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Minor refactor Co-authored-by: Jeff Fisher <xirzec@xirzec.com> * Post release automated changes for core releases (#18358) Post release automated changes for azure-core-client * Remove the word experimental in readmes (#18773) We have the word "Experimental" in the titles in the readme files for our core packages. My guess is that we started with this when we were working on core v2, forgot to remove it when core v2 went GA and all our newer core packages from them did a copy/paste :) @xirzec, @joheredi Am I missing something? * Update Changelog to include query param check (#18851) * Update Changelog to include query param check * Update sdk/core/core-client/CHANGELOG.md Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> Co-authored-by: Deyaaeldeen Almahallawi <dealmaha@microsoft.com> * fix reinstall native dependency (#18582) * Generate absolute path for symlink to reinstall native dependency Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com> Co-authored-by: Sarangan Rajamanickam <sarajama@microsoft.com> Co-authored-by: Jeff Fisher <xirzec@xirzec.com> Co-authored-by: Azure SDK Bot <53356347+azure-sdk@users.noreply.github.com> Co-authored-by: Ramya Rao <ramya.rao.a@outlook.com> Co-authored-by: praveenkuttappan <55455725+praveenkuttappan@users.noreply.github.com>
jeremymeng
added a commit
that referenced
this pull request
Feb 8, 2022
…8582) * Generate absolute path for symlink to reinstall native dependency
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-js
that referenced
this pull request
Apr 12, 2022
Add zoneredundancy property (Azure#18582) * Add zone redundant flag and fix label samples * add mutability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.