Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODEOWNERS #11516

Merged
merged 1 commit into from
Sep 26, 2020
Merged

Update CODEOWNERS #11516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@
# PRLabel: %Search
/sdk/search/ @xirzec @sarangan12

/sdk/applicationinsights/applicationinsights-query/ @divya-jay @geneh @alongafni
/sdk/operationalinsights/loganalytics/ @divya-jay @geneh @alongafni
Comment on lines +84 to +85
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend you take the entirety of /sdk/applicationinsights and /sdk/operationalinsights so that you can be kept across any other changes that may impact your libraries (some things fall outside the particular package directories.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be the case even if other directories are not owned by the team?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other directories are for the management packages. Assuming you are from the applicationinsights and operationalinsights teams, it would be in your interest to be aware of when the corresponding arm/management packages get updated. So, I would agree with @mitchdenny


/sdk/cognitiveservices/cognitiveservices-qnamaker-runtime/ @bingisbestest @nerajput1607
/sdk/cognitiveservices/cognitiveservices-qnamaker/ @bingisbestest @nerajput1607

Expand Down