Update CODEOWNERS #11516
Merged
Update CODEOWNERS #11516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchdenny
reviewed
Sep 26, 2020
Comment on lines
+84
to
+85
| /sdk/applicationinsights/applicationinsights-query/ @divya-jay @geneh @alongafni | ||
| /sdk/operationalinsights/loganalytics/ @divya-jay @geneh @alongafni |
There was a problem hiding this comment.
Recommend you take the entirety of /sdk/applicationinsights and /sdk/operationalinsights so that you can be kept across any other changes that may impact your libraries (some things fall outside the particular package directories.
There was a problem hiding this comment.
Should it be the case even if other directories are not owned by the team?
There was a problem hiding this comment.
The other directories are for the management packages. Assuming you are from the applicationinsights and operationalinsights teams, it would be in your interest to be aware of when the corresponding arm/management packages get updated. So, I would agree with @mitchdenny
mitchdenny
approved these changes
Sep 26, 2020
ramya-rao-a
approved these changes
Sep 26, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 15, 2021
add advisor track2 config (Azure#11516)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@divya-jay @alongafni FYI