Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Service Bus] Fix integration test failure on master #11122

Merged
merged 1 commit into from
Sep 9, 2020
Merged

[Service Bus] Fix integration test failure on master #11122

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions sdk/servicebus/service-bus/test/sendAndSchedule.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,10 +380,16 @@ describe("Sender Tests", () => {
});

describe("ServiceBusMessage validations", function(): void {
const sbClient = new ServiceBusClient(
"Endpoint=sb://a;SharedAccessKeyName=b;SharedAccessKey=c;EntityPath=d"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't removing the EntityPath=d" from the connection string have been enough to fix the test?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that is enough.
However, since this code was not part of any before section, this gets executed before mocha reports the describe block as being run, which makes it non-trivial to know where the failure is.
image

Making it part of the before section would help pinpoint this describe block if a failure happens.

);
const sender = sbClient.createSender("dummyQueue");
let sbClient: ServiceBusClient;
let sender: ServiceBusSender;

before(() => {
sbClient = new ServiceBusClient(
"Endpoint=sb://a;SharedAccessKeyName=b;SharedAccessKey=c;"
);
sender = sbClient.createSender("dummyQueue");
});

const longString =
"A very very very very very very very very very very very very very very very very very very very very very very very very very long string.";

Expand Down